Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocation of gradient array #5

Open
fzimmermann89 opened this issue Apr 6, 2022 · 1 comment
Open

Allocation of gradient array #5

fzimmermann89 opened this issue Apr 6, 2022 · 1 comment

Comments

@fzimmermann89
Copy link

Hi,

first of all, thank you for making this code available!

In the readme you mention one should allocate a buffer for g. But there is no way to actually make the library use that buffer, a new buffer will always be allocated inside lbfgsbminimize.
The example allocates a buffer outside, but this is never used.
Do you maybe have a version of the code that allows a user to hand over the gradient buffer to use or would you accept a PR changing the API of lbfgsbminimize to accept a buffer?

-Felix

@raymondyfei
Copy link
Owner

That was something in the old version.
Sure! Please do submit a PR for new features. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants