Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement of the note editing dialog #86

Open
swiftech opened this issue Aug 5, 2021 · 3 comments
Open

Improvement of the note editing dialog #86

swiftech opened this issue Aug 5, 2021 · 3 comments
Assignees

Comments

@swiftech
Copy link

swiftech commented Aug 5, 2021

Once upon a time, I opened a note dialog and typed something into the content, then I left this dialog open to something else, when I came back, I forgot what I did before and accidentally pressed the 'ESC' button, everything that I added to the content was lost. So could you add a new 'Save' button to the dialog and check the changes of content before closing it?

version: sciareto 1.5.0

@raydac raydac self-assigned this Aug 9, 2021
raydac added a commit that referenced this issue Aug 9, 2021
@raydac
Copy link
Owner

raydac commented Aug 9, 2021

I have made improvements, you can try snapshot

@swiftech
Copy link
Author

yes, the checking for 'esc' button works now, but I think it should also works on the "cancel" button of the dialog.

besides, If the "saving to disk" can be performed during the dialog opening, it will be very useful for me because sometimes I use the note dialog to edit very long content.

thanks.

@raydac
Copy link
Owner

raydac commented Aug 10, 2021

I have added functionality for cancel button and window close button in SciaReto, you can try snapshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants