Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoTest execution changes makeprg #449

Open
IlyasYOY opened this issue Apr 17, 2024 · 1 comment
Open

GoTest execution changes makeprg #449

IlyasYOY opened this issue Apr 17, 2024 · 1 comment

Comments

@IlyasYOY
Copy link

IlyasYOY commented Apr 17, 2024

As a user I want to be able:

  • run test :GoTest ./...
  • run :make verify or any other command from my Makefile.

You can reproduce the issue here: https://github.com/IlyasYOY/go-retry/

Steps:

  • neovim with go.nvim installed,
  • nvim .,
  • run :GoTest ./...,
  • run make verify

I expect running make's verify goal, but get:

:!go test verify 2>&1| tee /var/folders/f2/s841xw414zqfscfkvn76cfv40000gn/T/nvim.ilyasyoy/MYfAF5/5
package verify is not in std (/opt/homebrew/Cellar/go/1.22.2/libexec/src/verify)

(1 of 1): package verify is not in std (/opt/homebrew/Cellar/go/1.22.2/libexec/src/verify)

I found some clues in source code using "makeprg" search term:

vim.cmd([[setl makeprg=]] .. _GO_NVIM_CFG.go .. [[\ test]])
. Seems like a few commands change "makeprg" thus changing "makeprg" for the user. I tried to use float term to run commands and it works now, but I'd rather prefer old UX w/o running floating terminal.

I guess we might be able to same currently used "makeprg" and reset it after the job is done.

PS. Thanks for this plugin! I use it every day! I'd be glad to work on a solution if you think it may (or should) be fixed

@IlyasYOY
Copy link
Author

small workaround on client side: IlyasYOY/dotfiles@ab97e8b

ray-x added a commit that referenced this issue Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant