Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Leave config.txt options to the maintainer #259

Open
samnazarko opened this issue Apr 29, 2015 · 6 comments · May be fixed by #263
Open

Leave config.txt options to the maintainer #259

samnazarko opened this issue Apr 29, 2015 · 6 comments · May be fixed by #263

Comments

@samnazarko
Copy link

I think that these options should be left to the maintainer. On OSMC some of these values are already overlapping.

# NOOBS Auto-generated Settings:
hdmi_force_hotplug=1
config_hdmi_boost=4
overscan_left=24
overscan_right=24
overscan_top=16
overscan_bottom=16
disable_overscan=0
@lurch
Copy link
Collaborator

lurch commented May 4, 2015

@samnazarko I'm not sure why these (specific) values are being set, nor what impact not setting them would have on other NOOBS-installed OSes. Any ideas @maxnet , @popcornmix , @ghollingworth or @asb ?

What if I modified NOOBS so that it didn't append any overlapping options that were already present in the maintainer-supplied config.txt? (and didn't append any overscan_* settings if the existing config.txt said disable_overscan=1)

@samnazarko
Copy link
Author

Our desired settings are:

echo "arm_freq=850" >> config.txt
echo "core_freq=375" >> config.txt
echo "gpu_mem_256=112" >> config.txt
echo "gpu_mem_512=144" >> config.txt
echo "hdmi_ignore_cec_init=1" >> config.txt
echo "disable_overscan=1" >> config.txt
echo "start_x=1" >> config.txt

So disable_overscan seems to be the only overlapping one. Another option would be to add your custom settings before the maintainer's. Any customised settings will then get overwritten.

@popcornmix
Copy link

How about an option in the OS's json file to request config.txt is untouched by NOOBS?

@lurch
Copy link
Collaborator

lurch commented May 5, 2015

That's an even better idea, thanks @popcornmix :-)
(of course this new option would then mean it's up to the installed OS to decide whether to display over composite or HDMI, rather than 'inheriting' the output mode from NOOBS)

@samnazarko
Copy link
Author

Works for me.

@maxnet
Copy link
Collaborator

maxnet commented May 5, 2015

@samnazarko I'm not sure why these (specific) values are being set, nor what impact not setting them would have on other NOOBS-installed OSes. Any ideas @maxnet , @popcornmix , @ghollingworth or @asb ?

Don't know the reasoning behind the exact settings used now.
Recall in the original code only the output mode (hdmi preferred/safe mode/sdtv) was set.

samnazarko added a commit to samnazarko/noobs that referenced this issue May 24, 2015
samnazarko added a commit to samnazarko/noobs that referenced this issue Feb 6, 2016
samnazarko added a commit to samnazarko/noobs that referenced this issue Feb 6, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants