Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JPEG Control Reference in bcm2835-codec driver. Add control ID V4L2_CID_JPEG_RESTART_INTERVAL #6250

Open
wants to merge 2 commits into
base: rpi-6.6.y
Choose a base branch
from
Open

JPEG Control Reference in bcm2835-codec driver. Add control ID V4L2_CID_JPEG_RESTART_INTERVAL #6250

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab293e1
Add option V4L2_CID_JPEG_RESTART_INTERVAL
Jul 4, 2024
87c4a9e
Add option V4L2_CID_JPEG_RESTART_INTERVAL, set default value to 0
Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions drivers/staging/vc04_services/bcm2835-codec/bcm2835-v4l2-codec.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2423,6 +2423,17 @@ static int bcm2835_codec_s_ctrl(struct v4l2_ctrl *ctrl)
ret = 0;
break;

case V4L2_CID_JPEG_RESTART_INTERVAL:
if (!ctx->component)
break;

ret = vchiq_mmal_port_parameter_set(ctx->dev->instance,
&ctx->component->output[0],
MMAL_PARAMETER_JPEG_RESTART_INTERVAL,
&ctrl->val,
sizeof(ctrl->val));
break;

case V4L2_CID_JPEG_COMPRESSION_QUALITY:
if (!ctx->component)
break;
Expand Down Expand Up @@ -3536,6 +3547,12 @@ static int bcm2835_codec_open(struct file *file)
V4L2_CID_JPEG_COMPRESSION_QUALITY,
1, 100,
1, 80);

v4l2_ctrl_new_std(hdl, &bcm2835_codec_ctrl_ops,
V4L2_CID_JPEG_RESTART_INTERVAL,
1, 1000000,
1, 0);

if (hdl->error) {
rc = hdl->error;
goto free_ctrl_handler;
Expand Down