nullQuota leads to all null values on int/double attributes

[GPSHansl]

Describe the bug

nullQuota not working on number attributes, generator is always created as "ConstantGenerator(null, ...)" because parameter "SimpleTypeGeneratorFactory.createSpecificGenerator(..., nullable, ...)" (line 137ff) is not "false" .

To Reproduce

I created a simple "setup" which should create 20 datasets for ints, one without nullQuota, one with a "nullQuota" of "0.5".

<setup xmlns="https://www.benerator.de/schema/3.0.0">
	<generate type="test_withNullQuota" count="20" consumer="ConsoleExporter">
		<attribute name="number0" type="int" />
		<attribute name="number1" type="int" nullQuota="0.5" />
	</generate>
</setup>

Output:

test_withNullQuota[number0=1824111337, number1=[null]]
test_withNullQuota[number0=379015914, number1=[null]]
test_withNullQuota[number0=472367231, number1=[null]]
test_withNullQuota[number0=709014741, number1=[null]]
test_withNullQuota[number0=1042858519, number1=[null]]
test_withNullQuota[number0=1565994621, number1=[null]]
...
test_withNullQuota[number0=1891265572, number1=[null]]
test_withNullQuota[number0=62328256, number1=[null]]
test_withNullQuota[number0=935388951, number1=[null]]
test_withNullQuota[number0=366984187, number1=[null]]
test_withNullQuota[number0=1042493533, number1=[null]]

Expected behavior

On execution I'd expect, that on any entry the "number0" is filled with a random int number, that's what's happened.
I also expect that on about half the entries the "number1" is filled with a random int number, the rest of the entries have "number1" filled with "null".

test_withNullQuota[number0=1824111337, number1=[null]]
test_withNullQuota[number0=379015914, number1=[19194731]]
test_withNullQuota[number0=709014741, number1=[41651919]]
test_withNullQuota[number0=472367231, number1=[null]]
....
test_withNullQuota[number0=1042858519, number1=[null]]
test_withNullQuota[number0=1565994621, number1=[4919089]]
test_withNullQuota[number0=1602994586, number1=[null]]

Suspections

I suspect, the "nullable" parameter, derived within the "InstanceGeneratorFactory.createSingleInstanceGenerator(...) (line 59ff, derived at line 81) is not completely correct for the generator, since "nullQuota" "null" values should be created by some null-creator-wrapper, whereas the generator itself should always return non null values.

Benerator Version

• https://github.com/rapiddweller/rapiddweller-benerator-ce.git "development" branch

I hope my report is sufficient.
Maybe I have a big misunderstanding on attribute generation and nullQuotas.
Maybe I have just to set a "defaultNullQuota" ("context.getGeneratorFactory().getDefaultsProvider().defaultNullQuota() queried in "TypeGeneratorFactory.shouldNullifyEachNullable(...)") but I don't know how.

[ake2l]

Hey , thanks for using Benerator and for your detailed report. We are checking this and come back to you ASAP ... but first impression , it seems like a bug .