Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly report graph looks a bit strange #43

Open
sebastiaanspeck opened this issue Aug 7, 2019 · 6 comments
Open

Weekly report graph looks a bit strange #43

sebastiaanspeck opened this issue Aug 7, 2019 · 6 comments

Comments

@sebastiaanspeck
Copy link
Contributor

The weekly report looks a bit offset. See the difference in space between month 5 and 6 and the other months. May and June are wider in size

Schermafbeelding 2019-08-07 om 19 43 14

@range-of-motion
Copy link
Owner

This is probably due to the labeling. The chart's data is weekly, but the labels are monthly. To determine where to plot labels for the months, we're looking at the last week of each month, and plotting it there.

You can check out resources/views/reports/weekly_report.blade.php, as this is where it happens.

@sebastiaanspeck
Copy link
Contributor Author

Maybe change the labelling to Q1, 2, 3 and 4?

@range-of-motion
Copy link
Owner

Seems like an idea, but less specific. Harder to see exactly what happened in—for example—February?

@sebastiaanspeck
Copy link
Contributor Author

Or maybe the view can be toggled between monthly and Q1 etc?

@range-of-motion
Copy link
Owner

Good idea. I'd still prefer to see if we can fix the existing spacing "issue" tho.

@sebastiaanspeck
Copy link
Contributor Author

Agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants