SMG abstraction for families of MDPs #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheGreatfpmK
approved these changes
Nov 23, 2024
paynt/synthesizer/policy_tree.py
Outdated
| @@ -732,6 +679,7 @@ def split(self, family, prop, hole_selection, splitter, policy): | |||
| def evaluate_all(self, family, prop, keep_value_only=False): | |||
| assert not prop.reward, "expecting reachability probability propery" | |||
| game_solver = self.quotient.build_game_abstraction_solver(prop) | |||
| # game_solver.enable_profiling(True) | |||
There was a problem hiding this comment.
Remove profiling comments unless we want to do more performance testing
paynt/parser/drn_parser.py
Outdated
| @@ -27,7 +27,7 @@ def parse_drn(cls, sketch_path): | |||
| pomdp_path = sketch_path + '.tmp' | |||
| state_player_indications = DrnParser.pomdp_from_posmg(sketch_path, pomdp_path) | |||
| pomdp = DrnParser.read_drn(pomdp_path) | |||
| explicit_model = payntbind.synthesis.create_posmg(pomdp, state_player_indications) | |||
| explicit_model = payntbind.synthesis.posmgFromPomdp(pomdp, state_player_indications) | |||
There was a problem hiding this comment.
I think we mostly use the python naming conventions for bound C++ functions? So I would change this to posmg_from_pomdp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the use of SMG abstraction for families of MDPs:
GameAbstrationSolverTo enable the use of (PO)SMG abstraction for families of POMDPs:
PosmgandPosmgManagernow use templatesPosmgmodule now has an additional method to create a POSMG from an SMG and observability classes