Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify comment about .Values.monitoring.version #19

Open
lindhe opened this issue Aug 28, 2023 · 0 comments
Open

Clarify comment about .Values.monitoring.version #19

lindhe opened this issue Aug 28, 2023 · 0 comments

Comments

@lindhe
Copy link

lindhe commented Aug 28, 2023 •
edited
Loading

What's meant with this comment? It makes it seem like setting a semver range is useless, because it picks up the latest version anyway!

Also, it is very unclear as to what this installs. It should be clarifies that this "specifies which version of the rancher-monitoring chart to install".

cluster-template-examples/charts/values.yaml

Line 38 in dc5c201

# specify which version to install, can be semver range. If version is empty or is semver range, it will pick up the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lindhe