Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a GitHub CI cron job that open issues here for new Notion API changelog entries #234

Open
ramnes opened this issue May 17, 2024 · 9 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed task Something that has to be done at some point

Comments

@ramnes
Copy link
Owner

ramnes commented May 17, 2024

Most of the development / maintenance of this package is tied to Notion API changelog.

I already receive a notification every time a change happens in notion-sdk-js (watch ramnes/notion-sdk-js if you want them too), but sometime I misinterpret a commit and skip important changes.

A new issue here every time there's a new entry in the official changelog would be a better way to follow upstream changes!

@ramnes ramnes added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers task Something that has to be done at some point labels May 17, 2024
@trancethehuman
Copy link

Glad that this project is active :)

@ramnes
Copy link
Owner Author

ramnes commented Jun 11, 2024

Yes, it is. I would just like to see a bit more contributions from the community, I'm feeling quite alone these days. :)

@trancethehuman
Copy link

@ramnes do you have a list of issues for newcomers? I'll pick a few and work on them.

About to build Notion integration in my FastAPI app this month.

@ramnes
Copy link
Owner Author

ramnes commented Jun 11, 2024

Any issue with the good first issue tag!

https://github.com/ramnes/notion-sdk-py/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@AlexPantyukhin13
Copy link

AlexPantyukhin13 commented Aug 1, 2024

Has anyone already taken it? If not, I would like to try to make a contribution.

@ramnes
Copy link
Owner Author

ramnes commented Aug 1, 2024

Go ahead!

MassimoGennaro pushed a commit to MassimoGennaro/notion-sdk-py that referenced this issue Dec 19, 2024
MassimoGennaro added a commit to MassimoGennaro/notion-sdk-py that referenced this issue Dec 19, 2024
MassimoGennaro added a commit to MassimoGennaro/notion-sdk-py that referenced this issue Dec 19, 2024
@MassimoGennaro
Copy link

Hey @ramnes,

I recently started using this library for a project and thought I’d try to give back! I saw this issue and put together a potential solution in my fork here.

What I did:

  • Wrote a script that grabs the changelog, convert HTML to Markdown, saves it to a file to track what’s already been processed and opens issues only for new updates (here two examples).

  • Added a workflow to run the script every night.

Let me know what you think about this solution. Happy to tweak it or clean things up and open a PR if it seems useful.

@ramnes
Copy link
Owner Author

ramnes commented Dec 21, 2024

Hey @MassimoGennaro,

That's awesome, thank you so much for the help! It definitely seems useful, and I'd be really happy to get this merged. :)

Top of mind right now:

  • What would you think if we'd save less, e.g. only the date, title, and content md5?
  • I think it would be great to save the original blog post URL (using their anchor) and add it to the bottom of the issue.
  • We really need to make sure the script fails if their HTML structure changes, so that we can adapt and avoid doing crazy things with GitHub's API.

Don't feel obliged to make these changes, but please open a PR. Thanks again!

@MassimoGennaro
Copy link

Hi @ramnes
I had some spare time and work on the changes.

  • Now we save only date, title, and content md5 on the known_entries.json file (example here). The content md5 is also used to identify new entries.
  • The issue now contains the anchor URL the the original changelog entry and I assumed that a new label changelog can be added to tag these kind of issues (example here). If you agree, please remember to add this new label 😉
  • Now the script has some exception handlers to interrupt it when errors occur (including not expected HTML structure)

I tested it on my fork and everything seems working fine. I'm opening a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed task Something that has to be done at some point
Projects
None yet
Development

No branches or pull requests

4 participants