Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide MaterialUI via CDN #137

Open
1 task
GoelBiju opened this issue Jan 24, 2020 · 0 comments
Open
1 task

Provide MaterialUI via CDN #137

GoelBiju opened this issue Jan 24, 2020 · 0 comments
Labels
enhancement New feature or request not MVP not part of the minimum viable product

Comments

@GoelBiju
Copy link
Contributor

GoelBiju commented Jan 24, 2020

Description:
This issue has been branched from #101 .

With SciGateway updated to MaterialUI v4 we can provide the library via CDN (ADR 7).

We need to investigate if there is any benefit in providing the whole library once as opposed to making each plugin import only the component it needs to (though this may lead to multiple imports of the same component). We will also need to look into how the bundle size compares with each method; this requires the packages/plugins to be in a position where they are nearly complete in order to compare bundle sizes - see minimising bundle size.

Acceptance criteria:

  • Investigate which method results in less code being downloaded to the client; external dependency vs tree-shaking.
@GoelBiju GoelBiju added enhancement New feature or request not MVP not part of the minimum viable product labels Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request not MVP not part of the minimum viable product
Projects
None yet
Development

No branches or pull requests

1 participant