Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider orphaned attachment files #53

Open
joelvdavies opened this issue Oct 18, 2024 · 0 comments
Open

Consider orphaned attachment files #53

joelvdavies opened this issue Oct 18, 2024 · 0 comments
Labels
question Further information is requested

Comments

@joelvdavies
Copy link
Collaborator

Joshua pointed out an upload that fails after the original metadata is posted could be deleted by another user. This would leave the file in the object store while not being present in the database. Two thoughts come to mind:

  1. We do the same as images and route the attachment upload through the API (this will increase the load on the service - particularly if there are many large uploads at once, but we could ensure deletion only occurs fully)
  2. We have some sort of script to detect and remove orphaned attachments

It is possible even 1. cannot completely eliminate the possibility - if the first part of a multipart upload succeeds and the rest fails, although I suspect it would be a lot rarer.

@joelvdavies joelvdavies added the question Further information is requested label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
Status: Backlog
Development

No branches or pull requests

1 participant