Modify dialogue error messages when editing a catalogue item that has child elements #1136 #1165
+80
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…item has children - more user friendly - maunfacturer_id replaced by the actual manufacturer
- fixes failing linting test - fixes mistakes in cypress test - adds manufacturerList to dependency array - adds helpful comments
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1165 +/- ##
===========================================
- Coverage 99.23% 99.16% -0.08%
===========================================
Files 88 88
Lines 17876 17941 +65
Branches 2123 2949 +826
===========================================
+ Hits 17740 17791 +51
- Misses 135 149 +14
Partials 1 1 ☔ View full report in Codecov by Sentry. |
joshuadkitenge
requested changes
Dec 18, 2024
Comment on lines
+394
to
+398
| const message = response.detail.replace( | ||
| "so the following fields cannot be updated: manufacturer_id, properties", | ||
| ("so you cannot update the properties, and the manufacturer cannot be changed from " | ||
| + manufacturerName?.name) | ||
| ) |
There was a problem hiding this comment.
Instead of replacing the text directly in the backend response, consider moving this string transformation entirely to the frontend. This approach will ensure consistency in the response formatting, prevent future inconsistencies, and make it easier to manage localization or text changes.
Comment on lines
+1111
to
+1115
| screen.getByText( | ||
| 'Catalogue item has child elements, so you cannot update the properties, ' | ||
| + 'and the manufacturer cannot be changed' | ||
| ) | ||
| ).toBeInTheDocument(); |
There was a problem hiding this comment.
The error message is missing the name of the manufacturer
Comment on lines
+588
to
+594
| cy.findByRole('button', { name: 'Finish'}).click(); | ||
| cy.findByRole('dialog') | ||
| .should('be.visible') | ||
| .within(() => { | ||
| cy.contains('Catalogue item has child elements, so you cannot update the properties, ' | ||
| + 'and the manufacturer cannot be changed') | ||
| }); |
asuresh-code
requested changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modifies the error message to be more user friendly. Includes displaying the actual manufacturer name.
Adds cypress tests and add/modifies unit tests.
As seen here.
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
Resolves #1136