From 6d7b5ac9cf9bcd3dae9913b477d962f4afe1e501 Mon Sep 17 00:00:00 2001
From: Anand Rajagopal <anrajag@amazon.com>
Date: Thu, 29 Feb 2024 20:41:37 +0000
Subject: [PATCH] Send a slice of values to callback function instead of
 references

Signed-off-by: Anand Rajagopal <anrajag@amazon.com>
---
 provider/mem/mem.go |  4 ++--
 store/store.go      | 13 ++++++-------
 store/store_test.go |  2 +-
 3 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/provider/mem/mem.go b/provider/mem/mem.go
index 0e39ba1d5f..bb452cb4bc 100644
--- a/provider/mem/mem.go
+++ b/provider/mem/mem.go
@@ -100,13 +100,13 @@ func NewAlerts(ctx context.Context, m types.Marker, intervalGC time.Duration, al
 		logger:    log.With(l, "component", "provider"),
 		callback:  alertCallback,
 	}
-	a.alerts.SetGCCallback(func(alerts []*types.Alert) {
+	a.alerts.SetGCCallback(func(alerts []types.Alert) {
 		for _, alert := range alerts {
 			// As we don't persist alerts, we no longer consider them after
 			// they are resolved. Alerts waiting for resolved notifications are
 			// held in memory in aggregation groups redundantly.
 			m.Delete(alert.Fingerprint())
-			a.callback.PostDelete(alert)
+			a.callback.PostDelete(&alert)
 		}
 
 		a.mtx.Lock()
diff --git a/store/store.go b/store/store.go
index 83f1495a0f..6b8c6c948e 100644
--- a/store/store.go
+++ b/store/store.go
@@ -34,21 +34,21 @@ var ErrNotFound = errors.New("alert not found")
 type Alerts struct {
 	sync.Mutex
 	c  map[model.Fingerprint]*types.Alert
-	cb func([]*types.Alert)
+	cb func([]types.Alert)
 }
 
 // NewAlerts returns a new Alerts struct.
 func NewAlerts() *Alerts {
 	a := &Alerts{
 		c:  make(map[model.Fingerprint]*types.Alert),
-		cb: func(_ []*types.Alert) {},
+		cb: func(_ []types.Alert) {},
 	}
 
 	return a
 }
 
 // SetGCCallback sets a GC callback to be executed after each GC.
-func (a *Alerts) SetGCCallback(cb func([]*types.Alert)) {
+func (a *Alerts) SetGCCallback(cb func([]types.Alert)) {
 	a.Lock()
 	defer a.Unlock()
 
@@ -71,15 +71,14 @@ func (a *Alerts) Run(ctx context.Context, interval time.Duration) {
 
 func (a *Alerts) gc() {
 	a.Lock()
-	defer a.Unlock()
-
-	var resolved []*types.Alert
+	var resolved []types.Alert
 	for fp, alert := range a.c {
 		if alert.Resolved() {
 			delete(a.c, fp)
-			resolved = append(resolved, alert)
+			resolved = append(resolved, *alert)
 		}
 	}
+	a.Unlock()
 	a.cb(resolved)
 }
 
diff --git a/store/store_test.go b/store/store_test.go
index 485c39ceb4..1578d6edce 100644
--- a/store/store_test.go
+++ b/store/store_test.go
@@ -79,7 +79,7 @@ func TestGC(t *testing.T) {
 		done        = make(chan struct{})
 		ctx, cancel = context.WithCancel(context.Background())
 	)
-	s.SetGCCallback(func(a []*types.Alert) {
+	s.SetGCCallback(func(a []types.Alert) {
 		n += len(a)
 		if n >= len(resolved) {
 			cancel()