Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete underscore near logos #807

Open
AFimiani opened this issue Feb 24, 2024 · 4 comments
Open

Delete underscore near logos #807

AFimiani opened this issue Feb 24, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request hacktoberfest for hacktoberfest

Comments

@AFimiani
Copy link

Description

The logos in the README.md have underscores near them, which aesthetically would look better without them.

Possible Implementation

I managed to achieve the same result by using Markdown syntax instead of HTML for embedding the images with links. Here's how I did it:

Before:
<a href="https://www.example.com" target="_blank" rel="noreferrer"> <img src="logo_url" alt="logo_with_underscore" width="40" height="40"/> </a>

After:
[<img src="logo_url" alt="logo without underscore" width="40" height="40"/>](https://www.example.com)

By using Markdown syntax, I was able to remove the underscores from the alt text of the images, maintaining the href functionality and the desired dimension of the icon

@AFimiani AFimiani added enhancement New feature or request hacktoberfest for hacktoberfest labels Feb 24, 2024
@g-savitha
Copy link
Collaborator

g-savitha commented Feb 25, 2024

Would you like to work on this? @AFimiani

@prabhanshjn
Copy link

Hi @g-savitha ,
I can try to work on this issue.
Can you assign it to me.
Thanks

@prabhanshjn
Copy link

Hi @g-savitha ,
I have solved the issue and created a PR: #812
Please check it out,
Thanks!

@prabhanshjn
Copy link

Hi @g-savitha ,
Can this be approved thanks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest for hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants