Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRIGGER_AS_BUTTON default issue with START/SELECT buttons #44

Open
ghost opened this issue Sep 17, 2015 · 29 comments
Open

TRIGGER_AS_BUTTON default issue with START/SELECT buttons #44

ghost opened this issue Sep 17, 2015 · 29 comments

Comments

@ghost
Copy link

ghost commented Sep 17, 2015

TRIGGER_AS_BUTTON = true seems to be the worse default choice, because it disables START and SELECT buttons from working altogether in most games I tried (Mark of the Ninja, Bit Trip Runner 2 as example). If the triggers are used as a throttle, this is fixed. I would suggest changing the default setting to false.

@raelgc
Copy link
Owner

raelgc commented Sep 17, 2015

Hi @mystrdat, thanks for reporting this issue.

@sergiobenrocha2, @gyates100895, @mainmachine, @mhalano any thoughts about this?

@mhalano
Copy link

mhalano commented Sep 17, 2015

I think is a question which changes for each game, but for I think set to false could be a good idea. We just need to test with Steam if triggers is correctly recognized.

@melo0187
Copy link

Do you guys need any help testing this? I will be home on Wednesday, have a XBox 360 Wireless controller, Steam installed and always use the driver with TRIGGER_AS_BUTTON = false.

@raelgc
Copy link
Owner

raelgc commented Sep 21, 2015

@melo0187 Would be awesome if you can double check this on Steam :)

@melo0187
Copy link

@raelgc will do and report back on Wednesday =)

@mainmachine
Copy link
Collaborator

Since we know the behavior might be different with different games, might it make sense to start a list of games and their behavior with the trigger variable set to both cases?

We'll need to test Steam Big Picture mode as well... IIRC that works just fine with default settings (i.e. trigger=false).

@ghost
Copy link

ghost commented Sep 21, 2015

@mainmachine I believe the default is true, which is issue.

@mainmachine
Copy link
Collaborator

Sorry, good point - that's what I meant, of course. The default works for Big Picture last I checked. I won't be in a position to verify until this weekend, but if someone else can check this before then...?

@mhalano
Copy link

mhalano commented Sep 21, 2015

I can‘t do this. I having some troubles with xboxdrv and xpad because i
updated to linux 4.2.
Em 21/09/2015 13:54, "David Martinka" [email protected] escreveu:

Sorry, good point - that's what I meant, of course. The default works for
Big Picture last I checked. I won't be in a position to verify until this
weekend, but if someone else can check this before then...?


Reply to this email directly or view it on GitHub
#44 (comment)
.

@melo0187
Copy link

So finally catching a break from work today.

I started Steam BPM a moment ago just to notice that they changed the UI a bit and you can't assign buttons for your controller anymore. However I have a few games I could test for you guys. Any preferences? Here is the list of games I could test (if diskspace allows it...):
http://steamcommunity.com/id/melo0187/games/?tab=all

Just let me know which one are of biggest interest and I will give it a try.

@mainmachine
Copy link
Collaborator

@mhalano - nice collection. :)

I would say any of the platformers should be higher priority. Mark of the Ninja, Trine, etc.

@melo0187
Copy link

@mainmachine you got the wrong guy in the mention, so I did not see your input and went ahead and tried Middle-Earth: Shadow of Mordor, because that is the most talked Linux port atm I guess. TRIGGER_AS_BUTTON = false does work. You can both enter stealth (RT) and enter focus for bow shots (LT).

On another note: The D-Pad does not work, but if I can find out some more about that, it might be worth its own issue.

Will try MotN and Trine next (hoping that Shadow of Mordor left enough space on my Dual-Boot SSD... that game is huge óÒ).

@mainmachine
Copy link
Collaborator

@mhalano - sorry, I guess I haven't been getting as much sleep as I should. :/

@melo0187 - nice collection. :)

@melo0187
Copy link

Finally reporting back... sorry guys, got hooked on Middle-Earth: Shadow of Mordor ^^

Instead of checking with more games if TRIGGER_AS_BUTTON = false is a good idea (it is working in Steam BPM and Middle-Earth: Shadow of Mordor), I hunted down the issue with the d-pad not working.

I did not find a way to have a working d-pad in both Steam PBM and Middle-Earth: Shadow of Mordor when using MIMIC_XPAD=true. However setting MIMIC_XPAD=false completely messed up my axis, which were then swapped with one another. Thankfully xboxdrv is highly customizable and I managed to fix the axis swapping with XBOXDRV_OPTIONS="--axismap rt=lt,lt=X2,-Y2=rt,-X2=Y2".

My complete /etc/default/xboxdrvfile now looks like this:

# Defaults for xboxdrv service

# If enabled, can present problems on wine games
FORCE_FEEDBACK=true

# Make triggers work like buttons instead of zaxis
TRIGGER_AS_BUTTON=false

# Mimic xpad buttons
MIMIC_XPAD=false

# Additional options that are passed to xboxdrv (see xboxdrv man pages).
# These are appended once during start
XBOXDRV_OPTIONS="--axismap rt=lt,lt=X2,-Y2=rt,-X2=Y2"

# Edit each block to give each controller slot its own options.
# These are appended last for their respective slots
CONTROLLER0_OPTIONS=""
CONTROLLER1_OPTIONS=""
CONTROLLER2_OPTIONS=""
CONTROLLER3_OPTIONS=""

With this I have everything working (but force feedback...) in Steam BPM and (as a consequence of having everything working in Steam BPM I guess) also in Middle-Earth: Shadow of Mordor.

Will test with Trine next.

@melo0187
Copy link

Trine Enchanted Edition is working just fine with TRIGGER_AS_BUTTON=false
Next up: Mark of the Ninja

@melo0187
Copy link

The configuration I posted 2 comments up is not working at all for Mark of the Ninja. Apparently the game does not behave the same as Steam in BPM.

I reverted the configuration file to its original state and changed only TRIGGER_AS_BUTTON from true to false. Mark of the Ninja does work without any problems that way.

But it is a shame that Steam BPM and some games that don't get their controller setup from Steam runtime behave differently with the same configuration, because as stated in the comments above, with the default configuration the d-pad does not work in Steam BPM.

@raelgc
Copy link
Owner

raelgc commented Sep 28, 2015

So, if I correctly understood:

  • TRIGGER_AS_BUTTON = true: it disables START and SELECT in some games;
  • TRIGGER_AS_BUTTON = false: it disables d-pad in some games.

@melo0187
Copy link

@raelgc I am afraid it is way more messed up than that.

What I was able to see is that TRIGGER_AS_BUTTON did not make a difference for the d-pad, but MIMIC_XPADdoes, at least for Steam and games that behave like Steam.

With MIMIC_XPAD=true the d-pad is not working in Steam BPM and therefor not working in games that rely on the Steam runtime for the controller setup afaik.

So the initial comment for this issue might be true for Mark of the Ninja but than again Mark of the Ninja seems to do its own thing with the controller and does not mirror the controller setup of Steam BPM.

However, from my experience so far, it is safe to set TRIGGER_AS_BUTTON to false, since it does not break anything (remember: For Steam d-pad is broken no matter the value of TRIGGER_AS_BUTTON but because of MIMIC_XPAD=true)

@raelgc
Copy link
Owner

raelgc commented Sep 28, 2015

Thanks for clarify this, @melo0187.

So, maybe, we should focus in a default configuration friendly to Steam... what do you guys think?

@mhalano
Copy link

mhalano commented Sep 29, 2015

I think the Steam is the major game platform for Linux so support to Steam
is mandatory. I think the option "mimic_xpad" set to true can make the
things work fine.

2015-09-28 12:21 GMT-03:00 Rael Gugelmin Cunha [email protected]:

Thanks for clarify this, @melo0187 https://github.com/melo0187.

So, maybe, we should focus in a default configuration friendly to Steam...
what do you guys think?


Reply to this email directly or view it on GitHub
#44 (comment)
.

Marcos Alano

P: Por que este email é tão curto?

R: http://five.sentenc.es

@melo0187
Copy link

@mhalano but what about the d-pad issue then? I was not able to get the d-pad working with MIMIC_XPAD=true.

@mhalano
Copy link

mhalano commented Sep 29, 2015

@melo0187 Did you tested in jstest-gtk?

@melo0187
Copy link

@mhalano I used the Joystick app (that is what it is called in the dash and it might be jstest-gtk?), but it is not worth much since what I saw there was very different from what Steam does with the controller.

@mhalano
Copy link

mhalano commented Sep 29, 2015

@melo0187 I did some tests and with "mimic_xpad" set to false the joystick is recognized better by the jstest-gtk application. The problem is: with option set to false the joystick is unconfigurable via Big Picture mode.

@melo0187
Copy link

@mhalano what exactly do you mean with "the joystick is unconfigurable via Big Picture mode"?

That you can not properly use the gamepad in Steam BPM?

Or that you can't remap the buttons, axis and triggers of your gamepad withing the Steam BPM user interface?

The latter is because of a Steam update and is not related to the use of MIMIC_XPAD=false in my opinion.

@mhalano
Copy link

mhalano commented Sep 30, 2015

@melo0187 Joystick works, but I can't remap. I think this is important for user experience. for sure isn't related to MIMIC_XPAD=false, but again, damages the user experience. There's a way to show again configuration in BPM or we should open a bug report?

@melo0187
Copy link

@mhalano i have not found a way to reach the old gamepad configuration screen in Steam BPM. Feel free to open up an issue over at Valve. I will make sure to +1 it, since I too think that dropping the gamepad configuration screen in Steam BPM is a step backwards.

@mhalano
Copy link

mhalano commented Sep 30, 2015

I created the bug ValveSoftware/steam-for-linux#4044 so please post a note or fix and missing informations.

@raelgc
Copy link
Owner

raelgc commented Jan 13, 2016

So, I'll set TRIGGER_AS_BUTTON to false by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants