fix: [AXIMST-657] Certificates page - update condition to show header buttons #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PKulkoRaccoonGang
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
@khudym A little clarification, do we need to update the tests?
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## ts-develop #205 +/- ##
=============================================
Coverage ? 89.51%
=============================================
Files ? 651
Lines ? 10892
Branches ? 2258
=============================================
Hits ? 9750
Misses ? 1103
Partials ? 39 ☔ View full report in Codecov by Sentry. |
I did lots of changes to tests in the upstream PR so I`m going to add them there |
vladislavkeblysh
force-pushed
the
ts-develop
branch
2 times, most recently
from
dd8a0f9
to
509070d
Compare
monteri
approved these changes
Mar 14, 2024
khudym
added a commit
that referenced
this pull request
Mar 14, 2024
… buttons (#205) * feat: [AXIMST-605] add file name to upload preview modal (#203) * fix: [AXIMST-657] Certificates update condition to show header buttons --------- Co-authored-by: vladislavkeblysh <[email protected]> Co-authored-by: Kyrylo Hudym-Levkovych <[email protected]>
khudym
added a commit
that referenced
this pull request
Mar 25, 2024
… buttons (#205) * feat: [AXIMST-605] add file name to upload preview modal (#203) * fix: [AXIMST-657] Certificates update condition to show header buttons --------- Co-authored-by: vladislavkeblysh <[email protected]> Co-authored-by: Kyrylo Hudym-Levkovych <[email protected]>
monteri
pushed a commit
that referenced
this pull request
Apr 1, 2024
… buttons (#205) * feat: [AXIMST-605] add file name to upload preview modal (#203) * fix: [AXIMST-657] Certificates update condition to show header buttons --------- Co-authored-by: vladislavkeblysh <[email protected]> Co-authored-by: Kyrylo Hudym-Levkovych <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AXIMST-657 Certificate action buttons and empty modes label are shown for course with created certificate and without mode that offers certificates.