feat: [AXIMST-517] request within the demo #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PKulkoRaccoonGang
approved these changes
Feb 26, 2024
monteri
reviewed
Feb 27, 2024
Comment on lines
102
to
104
| setTimeout(() => { | ||
| onClose(); | ||
| }, 1000); | ||
| }, 0); |
There was a problem hiding this comment.
is it needed to have timeout here? Maybe just onClose();?
There was a problem hiding this comment.
you are right, there is no need in timeout anymore!
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## ts-develop #187 +/- ##
=============================================
Coverage ? 89.56%
=============================================
Files ? 673
Lines ? 11317
Branches ? 2394
=============================================
Hits ? 10136
Misses ? 1143
Partials ? 38 ☔ View full report in Codecov by Sentry. |
monteri
approved these changes
Feb 27, 2024
ihor-romaniuk
pushed a commit
that referenced
this pull request
Feb 29, 2024
* feat: [AXIMST-517] request within the demo * refactor: [AXIMST-517] add changes after review --------- Co-authored-by: Kyrylo Hudym-Levkovych <[email protected]>
ihor-romaniuk
pushed a commit
that referenced
this pull request
Feb 29, 2024
* feat: [AXIMST-517] request within the demo * refactor: [AXIMST-517] add changes after review --------- Co-authored-by: Kyrylo Hudym-Levkovych <[email protected]>
khudym
added a commit
that referenced
this pull request
Mar 6, 2024
* feat: [AXIMST-517] request within the demo * refactor: [AXIMST-517] add changes after review --------- Co-authored-by: Kyrylo Hudym-Levkovych <[email protected]>
khudym
added a commit
that referenced
this pull request
Mar 25, 2024
* feat: [AXIMST-517] request within the demo * refactor: [AXIMST-517] add changes after review --------- Co-authored-by: Kyrylo Hudym-Levkovych <[email protected]>
monteri
pushed a commit
that referenced
this pull request
Apr 1, 2024
* feat: [AXIMST-517] request within the demo * refactor: [AXIMST-517] add changes after review --------- Co-authored-by: Kyrylo Hudym-Levkovych <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AXIMST-517 [Request within the Demo]