Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated API functions #100

Open
lukebakken opened this issue Jul 13, 2022 · 2 comments
Open

Remove deprecated API functions #100

lukebakken opened this issue Jul 13, 2022 · 2 comments
Milestone

Comments

@lukebakken
Copy link
Contributor

Follow-up to #96

Version 2 should remove deprecated API functions and "clean up" those that are left, perhaps coming up with a better name than PublishWithDeferredConfirm.

To be honest if you're publishing without confirmations the function should be called PublishButDontComplainWhenYouLoseData

@lukebakken lukebakken added this to the 2.0.0 milestone Jul 13, 2022
@lukebakken
Copy link
Contributor Author

lukebakken commented May 19, 2023

Also note that context is no longer used in publishing (#195, discussion).

@Zerpet
Copy link
Contributor

Zerpet commented May 22, 2023

I've been thinking of removing the deprecated functions and removing the *WithContext prefix, so that we go back to Publish() taking context as first argument. Same story for Consume, make the function that takes context the only one and remove the one that doesn't.

Since we are going 2.0, we could take this change to make these breaking changes.

Regarding #195, I think there is a point for using contexts in Publish, as it should not send the message if the context is cancelled. I don't think we can interrupt or cancel an RPC to the server once we sent the publish frame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants