Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASCO optimization doesn't work with QucsatorRF but works with Qucsator #830

Closed
ra3xdh opened this issue Jul 9, 2024 · 2 comments · Fixed by #843
Closed

ASCO optimization doesn't work with QucsatorRF but works with Qucsator #830

ra3xdh opened this issue Jul 9, 2024 · 2 comments · Fixed by #843
Assignees
Milestone

Comments

@ra3xdh
Copy link
Owner

ra3xdh commented Jul 9, 2024

The reason for this issue is that qucsator executable name is hardcoded inside ASCO sources. Also ASCO always assumes that qucsator is available from $PATH. This may make difficulties for running a portable version. The ways to resolve this:

  • Provide a patched version of ASCO with the next release
  • Submit a patch to ASCO that allows to set the path to qucsator excutable
@ra3xdh ra3xdh added the qucsator label Jul 9, 2024
@ra3xdh ra3xdh changed the title ASCO optimization doesn't work with Qucsator_rf but works with Qucsator ASCO optimization doesn't work with QucsatorRF but works with Qucsator Jul 9, 2024
@ra3xdh ra3xdh mentioned this issue Jul 11, 2024
@ra3xdh ra3xdh self-assigned this Jul 11, 2024
@ra3xdh
Copy link
Owner Author

ra3xdh commented Jul 11, 2024

I have prepared a patched version of ASCO here: https://github.com/ra3xdh/asco_qucs_s Compile and install this version if you need to run optimizer with Qucs-S+QucsatorRF. You have to set the environment variable ASCO_SIM_PATH to full path to qucsator_rf if you are using stable v24.2.1 release. For example ASCO_SIM_PATH=/usr/bin/qucsator_rf The version from Git applies this environment variable automatically. I have submitted a patch to ASCO developers. Let's wait for reaction. If the patch will be not accepted, I will provide the patched ASCO version with the next Qucs-S release.

@ra3xdh ra3xdh added the asco label Jul 11, 2024
@ra3xdh ra3xdh added this to the 24.3.0 milestone Jul 14, 2024
@ra3xdh ra3xdh added the bug label Jul 14, 2024
@ra3xdh
Copy link
Owner Author

ra3xdh commented Jul 15, 2024

I have contacted ASCO developers and they didn't advice to patch the ASCO. The #843 provides an another solution.

  • For Linux the temporary symlink qucsator pointing to qucsator_rf is created. This makes possible to run the system-wide installed vanilla ASCO and avoid the distribution of the patched ASCO version with DEB/RPM packages. This prevents a possible conflict with ASCO package on some distributions.
  • For Windows only patched ASCO version works. The approach using general.sh didn't work because the script name again is hardcoded inside ASCO. I will add a patched asco.exe in the Windows installer. This is not a problem for Windows.

Closing this as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant