Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeePassXC (KDBX4) support #6

Open
r4gus opened this issue Mar 11, 2024 · 9 comments
Open

KeePassXC (KDBX4) support #6

r4gus opened this issue Mar 11, 2024 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@r4gus
Copy link
Owner

r4gus commented Mar 11, 2024

KeePassXC got Passkey support with version 2.7.7 (https://keepassxc.org/blog/2024-03-10-2.7.7-released/). It's probably time to switch to KDBX4 to store credentials to offer compatibility.

Required Tasks:

  • Implement KDBX4 support
  • Write a script that translates from .trs to kdbx4
@r4gus r4gus added the enhancement New feature or request label Mar 11, 2024
@r4gus r4gus self-assigned this Mar 11, 2024
@r4gus
Copy link
Owner Author

r4gus commented Jul 23, 2024

I switched to a custom database format https://r4gus.github.io/ccdb/ because there are a few things in kdbx that I dislike. Nevertheless, adding kdbx4 support is still a good idea.

@r4gus
Copy link
Owner Author

r4gus commented Sep 2, 2024

Somebody would like kdbx4 support to use PassKeeZ for login and KeePassXC for credential management so I should start implementing KDBX4 or find a suitable C library. God I hate XML...

@r4gus r4gus changed the title Switch to KDBX4 Integrate with KeePassXC Sep 21, 2024
@r4gus r4gus changed the title Integrate with KeePassXC KeePassXC (KDBX4) support Sep 21, 2024
@r4gus
Copy link
Owner Author

r4gus commented Sep 21, 2024

For KDBX4 support we're going to use the keepassxc-cli tool. Implementing KDBX4 from scratch is doable but I don't really want to maintain it, mainly due to XML. This involves the following steps:

  • Fork KeePassXC and and export-passkey and import-passkey support for the command line tool
  • Refactor the PassKeeZ code and implement a generic Database type
  • Implement KDBX4 support for Database via keepassxc-cli

@frie
Copy link

frie commented Sep 23, 2024

For KDBX4 support we're going to use the keepassxc-cli tool. Implementing KDBX4 from scratch is doable but I don't really want to maintain it, mainly due to XML. This involves the following steps:

* [x]  Fork KeePassXC and and `export-passkey` and `import-passkey` support for the command line tool

* [ ]  Refactor the PassKeeZ code and implement a generic `Database` type

* [ ]  Implement KDBX4 support for `Database` via `keepassxc-cli`

IMO KBDX4 support would be nice, but still is a nice-to-have. Implement it, when it is easy, just to be in sync with some kind of "standard", but the benefit for users is limited. The benefit of KeePassXC is its cross compatibility with windows, but using PasskeeZ just on Linux is still more comfortable, and completely sufficient for my personal needs.

What I am missing with the only version being installable just now is a UI for key management. The ccdb CLI is ok, but not really comfortable from the UX point of view.

Maybe it would be easier do implement the interface used by chromium to manage the passkeys on my T2F2 stick? This is what chromium shows me here:
T2F2-manage-sign-in

When using PasskeeZ chromium recognizes the virtual device, but after entering the password I see this here:
PasskeeZ-manage-sign-in

There are some more shortcomings (ok, we are still at beta...) which I may file in another issue, and which I would prioritize against KBDX4 (e.g. multi-language-support)

@r4gus
Copy link
Owner Author

r4gus commented Sep 23, 2024

@frie is this a Plugin or how do you manage passkeys with Chromium?

@frie
Copy link

frie commented Sep 23, 2024

@frie is this a Plugin or how do you manage passkeys with Chromium?

See here for details, seems to be standard functionality of Chromium. I will also give a try to the "open-source-tool" mentioned in this article.

@r4gus
Copy link
Owner Author

r4gus commented Sep 23, 2024

I'll re-add credential management support. After that one should be able to use the chrome-tool. It's quite unfortunate that Chrome hides this within a sub-menu.

@frie
Copy link

frie commented Sep 23, 2024

fido2-manage by token2 (see here) also opens the PasskeeZ device and shows some information. Passkey management currently is disabled...

Bildschirmfoto vom 2024-09-24 00-05-27

Change PIN opens a terminal window, asks for old and new PIN and seems to do nothing at all. The PasskeeZ device obiously is accessed because the password dialogue comes up.

@r4gus
Copy link
Owner Author

r4gus commented Sep 24, 2024

The "passkey management" is probably coupled to the authenticatorCredentialManagement endpoint. I'll add it. The pin change button should be disabled for the authenticator because the clientPin flag is missing from the getInfo response map (which is equivalent to: "PIN based authentication is disabled and you can't enable it").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants