You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't think this can be done in a single release, but in general, we have the code that handles the R stuff (external pointers, geographies, etc.), the code that implements GEOS-like stuff using S2 classes, and a few wrappers to simplify S2 C++ stuff in the same files. The long-term goal, I think, would be to separate these three categories of things so that (1) other people that aren't using R can re-use some of the code and (2) maybe we can separate the building of the actual S2 library from the building of the R wrappers. That should make it easier to iterate on S2 but (but more complicated to add features, since they'd have to be added to the C API first).
This can be done slowly over a few releases...as a start, I think we can expose the S2Cell, S2CellId, and S2CellUnion methods as C wrappers since that will be new or almost new functionality. The MutableS2ShapeIndex and S2Shape, could come next since those get used for most of the implementations. The overlay bits (e.g., S2Builder) are probably the hardest to parameterize...we might have to make some C structures to make it work.
The text was updated successfully, but these errors were encountered:
I don't think this can be done in a single release, but in general, we have the code that handles the R stuff (external pointers, geographies, etc.), the code that implements GEOS-like stuff using S2 classes, and a few wrappers to simplify S2 C++ stuff in the same files. The long-term goal, I think, would be to separate these three categories of things so that (1) other people that aren't using R can re-use some of the code and (2) maybe we can separate the building of the actual S2 library from the building of the R wrappers. That should make it easier to iterate on S2 but (but more complicated to add features, since they'd have to be added to the C API first).
This can be done slowly over a few releases...as a start, I think we can expose the
S2Cell
,S2CellId
, andS2CellUnion
methods as C wrappers since that will be new or almost new functionality. TheMutableS2ShapeIndex
andS2Shape
, could come next since those get used for most of the implementations. The overlay bits (e.g., S2Builder) are probably the hardest to parameterize...we might have to make some C structures to make it work.The text was updated successfully, but these errors were encountered: