Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely rewrite logging system #646

Merged
merged 16 commits into from
Sep 1, 2023
Merged

Completely rewrite logging system #646

merged 16 commits into from
Sep 1, 2023

Conversation

ajax146
Copy link
Contributor

@ajax146 ajax146 commented Aug 31, 2023

This rewrites the bot logging system to be more versatile. This uses a better system to take into account private_channels and allows a simple way to disable all guild logging.

Replaces #615

Fixes #540
Fixes #585

@ajax146
Copy link
Contributor Author

ajax146 commented Aug 31, 2023

This mostly just makes the logging system more in line with the feature set of the rest of the bot. But it makes a few significant changes:

First, error logs do not have to have an exception with them anymore
Second, any other level of logs can have an exception

Additionally, DelayedLogger now ignores debug logs if debug is off, so the performance with using DelayedLogger will be increased.

Copy link
Contributor

@TheKrol TheKrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm stupid, it was a private channel

@ajax146 ajax146 merged commit 4793418 into main Sep 1, 2023
9 checks passed
@ajax146 ajax146 deleted the NewLoggingSystem branch September 1, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants