Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All role modifications now have reasons #619

Merged
merged 4 commits into from
Sep 1, 2023
Merged

All role modifications now have reasons #619

merged 4 commits into from
Sep 1, 2023

Conversation

ajax146
Copy link
Contributor

@ajax146 ajax146 commented Aug 23, 2023

Fixes #600

TheKrol
TheKrol requested changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@TheKrol TheKrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug when getting an application, It is trying to log the message.

@ajax146
Copy link
Contributor Author

ajax146 commented Sep 1, 2023

This is unrelated to the changes I've done here, this is a bug with logger

@ajax146 ajax146 merged commit 3828198 into main Sep 1, 2023
9 checks passed
@ajax146 ajax146 deleted the RoleReasons branch September 1, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheKrol TheKrol TheKrol approved these changes

Assignees
No one assigned
Labels
Extension: Application Extension: Gate Extension: Protect Extension: Role
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Role assignments should have reasons
2 participants
@ajax146 @TheKrol