Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Rules can be created without a deployment channel being configured #95

Open
pbartusch opened this issue Dec 17, 2021 · 3 comments
Labels

Comments

@pbartusch
Copy link
Collaborator

Steps to reproduce:

  • Start SMUI on a fresh database
  • Create Rules

Actual:

  • Rules can be created (but the assignment to a deployment channel is unclear, also they disappear once a deployment channel is configured properly - which is unexpected to the user).

Expected:

  • Deliver a warning to the user.
@pbartusch pbartusch added the bug label Dec 17, 2021
@epugh
Copy link
Contributor

epugh commented Dec 17, 2021

Thanks for opening this ticket... I was a bit confused if there was an idea that if a rule doesn't have a Deployment Channel (Rules Collection?) then maybe it applied to all of them. THanks for confirming that rules must be tied to a Deployment Channel.

As an aside, I think we need to get on the same page for this name!

@pbartusch
Copy link
Collaborator Author

Yeah. I think, rules will created with an empty string reference then.

Sorry for the confusion, I think renaming the SolrIndex concept and discussing the alternatives (Deployment Channel vs. Rules Collection) is an important topic (on its own). It's inconsistent through code, documentation and conversions right now :-(

@epugh
Copy link
Contributor

epugh commented Dec 17, 2021

Once we get a clear name, I'm happy to go do the refactoring... (Refactoring is my favorite Friday afternoon activity!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants