Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keycloak/check-for-host-configuration.sh echo with -e mangles windows path #143

Open
cgicgi opened this issue Feb 21, 2023 · 3 comments
Open

Comments

@cgicgi
Copy link

cgicgi commented Feb 21, 2023

-  echo -e "${ERROR}To make Keycloak work, you need to add the following line to your hosts file (/etc/hosts on Mac/Linux, c:\Windows\System32\Drivers\etc\hosts on Windows).${RESET}"
+  echo "${ERROR}To make Keycloak work, you need to add the following line to your hosts file (/etc/hosts on Mac/Linux, c:\Windows\System32\Drivers\etc\hosts on Windows).${RESET}"
@epugh
Copy link
Collaborator

epugh commented Feb 21, 2023

would you like to submit a PR? I don't have access to windows, so it would be great if you could submit a PR that passes on windows!

@cgicgi
Copy link
Author

cgicgi commented Feb 22, 2023

I'd love to - but don't have permissions to push my branch with the fix.

@epugh
Copy link
Collaborator

epugh commented Feb 22, 2023

Just fork this project into your own namespace, and submit a PR ;-) That gives us a nice review cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants