Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some providers do not have schemes #5

Closed
raae opened this issue Aug 1, 2018 · 2 comments
Closed

Some providers do not have schemes #5

raae opened this issue Aug 1, 2018 · 2 comments

Comments

@raae
Copy link
Member

raae commented Aug 1, 2018

The ombed.com provided list is not complete. We should probably add a way to patch providers ourselves. Most notably YouTube has no schemes.

I have created an issue and commented on an issue in the oembed project.
@raae
Copy link
Member Author

raae commented Aug 15, 2018

I am thinking there should also be an option for developers to add schemas. In case we do not get them all in our fix.

raae added a commit that referenced this issue Aug 18, 2018
@raae
Schemas #5 (#21)
3411f27 
* Refactored ammend code into its own function.

* Added possibility to amend provider list. Adding support for YouTube and https Flickr.

* Added amCharts Live Editor hakcs.

* Added reddit script.

* Added MixCloud and Nasjonalbiblioteket hacks.
@raae
Copy link
Member Author

raae commented May 14, 2019

There is already possible to amend schemes, but not add providers. The latter has gotten its own issue #58.

@raae raae closed this as completed May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@raae