New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Equation .. math:: is misleading #580

Open

brunotakara opened this issue Dec 25, 2023 · 0 comments

brunotakara commented Dec 25, 2023 •

edited

Loading

https://github.com/qubvel/segmentation_models/blame/e951c6747f75fa9e7240816d1c79dd2e66813123/segmentation_models/losses.py#L54

dice loss returns 1 - f_score so it is working fine but the commentary has an issue at line 59

L(tp, fp, fn) = \frac{(1 + \beta^2) \cdot tp} {(1 + \beta^2) \cdot fp + \beta^2 \cdot fn + fp}

is dividided by a term o fp that is actually tp, the term (1 + \beta^2) \cdot fp

should be L(tp, fp, fn) = \frac{(1 + \beta^2) \cdot tp} {(1 + \beta^2) \cdot tp + \beta^2 \cdot fn + fp}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment