Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updater: Support delta updates #1167

Merged
merged 1 commit into from
Jan 19, 2024
Merged

updater: Support delta updates #1167

merged 1 commit into from
Jan 19, 2024

Conversation

crozzy
Copy link
Contributor

@crozzy crozzy commented Dec 1, 2023 •
edited
Loading

TODO:

  • Doc strings
  • Move added SQL to embedded .sql file? (not going to tackle this in the same PR as we're now touching an existing method)

@codecov Codecov
Copy link

codecov bot commented Dec 1, 2023 •
edited
Loading

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (d372652) 52.63% compared to head (2203122) 53.37%.
Report is 1 commits behind head on main.

Files Patch % Lines
datastore/postgres/updatevulnerabilities.go 83.33% 9 Missing and 6 partials ⚠️
libvuln/updates/manager.go 50.00% 10 Missing and 1 partial ⚠️
libvuln/jsonblob/jsonblob.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1167      +/-   ##
==========================================
+ Coverage   52.63%   53.37%   +0.73%     
==========================================
  Files         224      224              
  Lines       17068    17166      +98     
==========================================
+ Hits         8984     9162     +178     
+ Misses       7264     7165      -99     
- Partials      820      839      +19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crozzy crozzy force-pushed the delta-updates branch 11 times, most recently from 10406aa to f3ab332 Compare December 13, 2023 21:28
@crozzy crozzy added the needs-changelog Label for PRs that need a changelog note. label Dec 13, 2023
@crozzy crozzy force-pushed the delta-updates branch 4 times, most recently from ba7b016 to 22d8e7b Compare December 19, 2023 23:05
@crozzy crozzy marked this pull request as ready for review January 4, 2024 18:10
@crozzy crozzy requested a review from a team as a code owner January 4, 2024 18:10
@crozzy crozzy requested review from hdonnay and removed request for a team January 4, 2024 18:10
hdonnay
hdonnay requested changes Jan 11, 2024
View reviewed changes
Copy link
Member

@hdonnay hdonnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a few changes, then the metrics addition.

datastore/postgres/updatevulnerabilities.go Outdated Show resolved Hide resolved
datastore/postgres/updatevulnerabilities.go Outdated Show resolved Hide resolved
datastore/postgres/updatevulnerabilities.go Outdated Show resolved Hide resolved
datastore/postgres/updatevulnerabilities.go Show resolved Hide resolved
datastore/postgres/updatevulnerabilities.go Show resolved Hide resolved
libvuln/updates/manager.go Outdated Show resolved Hide resolved
libvuln/jsonblob/jsonblob.go Outdated Show resolved Hide resolved
libvuln/driver/updater.go Outdated Show resolved Hide resolved
datastore/updater.go Outdated Show resolved Hide resolved
datastore/postgres/updatevulnerabilities.go Show resolved Hide resolved
@crozzy crozzy requested a review from hdonnay January 18, 2024 23:02
@crozzy
updater: Support delta updates
2203122 
Adds the DeltaUpdateVulnerabilities() method to the matcher store
interface and a postgres implementation to be able to handle partial
vulnerability information from sources.

Signed-off-by: crozzy <[email protected]>
@crozzy
Copy link
Contributor Author

crozzy commented Jan 19, 2024

/fast-forward

@github-actions github-actions bot merged commit 2203122 into quay:main Jan 19, 2024
7 checks passed
@hdonnay hdonnay removed the needs-changelog Label for PRs that need a changelog note. label Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdonnay hdonnay hdonnay approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crozzy @hdonnay