Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alpine: support edge vulnerabilities #1101

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

RTann
Copy link
Contributor

@RTann RTann commented Oct 9, 2023

Followup to #1091 to support Alpine edge vulnerabilities

@RTann RTann requested a review from a team as a code owner October 9, 2023 23:35
@RTann RTann requested review from hdonnay and crozzy and removed request for a team October 9, 2023 23:35
@RTann RTann force-pushed the alpine-vuln-support branch from 4f1527a to 37b3480 Compare October 10, 2023 00:05
@RTann
Copy link
Contributor Author

RTann commented Oct 10, 2023

I updated my local Clair repo to use this version of ClairCore, and I ran the matcher. I found logs showing it was running the Alpine edge updater

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (25d5e29) 52.04% compared to head (faffb8e) 52.11%.

Files Patch % Lines
alpine/release.go 66.66% 2 Missing ⚠️
alpine/distributionscanner.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1101      +/-   ##
==========================================
+ Coverage   52.04%   52.11%   +0.07%     
==========================================
  Files         220      220              
  Lines       16839    16843       +4     
==========================================
+ Hits         8764     8778      +14     
+ Misses       7264     7257       -7     
+ Partials      811      808       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RTann RTann force-pushed the alpine-vuln-support branch 5 times, most recently from bd145ff to 39df9bb Compare October 23, 2023 17:14
Copy link
Contributor

@crozzy crozzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit

@RTann RTann requested a review from crozzy November 6, 2023 19:47
@RTann RTann force-pushed the alpine-vuln-support branch 6 times, most recently from caf50d1 to 7585480 Compare November 17, 2023 23:26
@RTann RTann force-pushed the alpine-vuln-support branch 2 times, most recently from 920cfbc to c9647a0 Compare November 27, 2023 18:55
@RTann RTann force-pushed the alpine-vuln-support branch from c9647a0 to faffb8e Compare November 29, 2023 01:48
@hdonnay
Copy link
Member

hdonnay commented Nov 29, 2023

/fast-forward

@github-actions github-actions bot merged commit faffb8e into quay:main Nov 29, 2023
9 checks passed
@hdonnay hdonnay added the needs-changelog Label for PRs that need a changelog note. label Nov 29, 2023
@RTann RTann deleted the alpine-vuln-support branch November 30, 2023 01:33
@hdonnay hdonnay removed the needs-changelog Label for PRs that need a changelog note. label Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants