Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interest in automatically applying OpenRewrite best practices on pull requests? #189

Open
timtebeek opened this issue Jul 23, 2024 · 2 comments

Comments

@timtebeek
Copy link
Contributor

timtebeek commented Jul 23, 2024

Hi all! I was wondering if you'd be interested in having some best practices automatically applied to pull requests here. We added these friendly nudges to our own repositories a while ago, and they've really helped standardize our contributions. In practice what you'd get is one additional workflow run per PR, which comments code suggestions if it finds changes when applying best practices here.

You can see an example of such a comment here:

The full list of best practices are described here.

An example of what this would look like for a Maven project like this one is here.

A more detailed write up of what we've done and why can be found here.

I hope that's of use to you here; I'd be happy to open a PR if you'd indeed be open to adopting this practice.

@timtebeek
Copy link
Contributor Author

As a first step this change would allow running those best practices once as a one-off:
main...timtebeek:quarkus-updates:best-practices-via-rewrite.yml

Then from there we can review any new issues coming in on PRs automatically, with a convenient local option to prevent these through the run button shown here.
image

@ia3andy
Copy link
Collaborator

ia3andy commented Aug 14, 2024

Thanks @timtebeek!

@gsmet wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants