-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NoiseModelFromGoogleNoiseProperties
should raise an error when simulations use qubits not on the device or an uncompiled circuit
#6608
Comments
Hi, I'm interested in taking on this issue. Will look more into the current implementation. |
@shef4 thanks for offering to help |
Hi @NoureldinYosri , please assign this issue to another developer. Thank you for learning opportunity. The cirq meetings are a great place for students to learn about real world development practices and I hope they continue to help new and experienced developers grow and learn. |
Hi @NoureldinYosri Can i take this up |
@nivedha1 sure, thanks for offering to help |
I was able to implement the first part of the problem "To raise an error when trying to run simulations with qubits not on the device" But for "A circuit not compiled to a supported gateset" part, Im unable to figure out a way to get the target gateset from the compiled gateset to check if it is part of supported gateset. Please Advise Thanks! |
Hi @nivedha1, from the comment made about this issue #6607 (comment) by cosenal
you might need you use this function to check which gates are supported by the device |
Honestly, I'm not sure.
@NoureldinYosri would need to shed more light on the matter. Hope this helps! |
@shef4 |
Hi @nivedha1, Honestly not sure, but this is a good question to bring up in the Cirq bi-weekly meetings |
Hi, please check #6607 (comment) for the methods that you will need ... namely This issue isn't about talking to the actualy hardware but about fixing a simulation that tries to mimic the hardware... the mimicing of the hardware happens through the noise model. this issue is about validating that the circuit is consistent with the noise model. |
Description of the issue
Noisy Simulation describes how to run simulations with realistic noise obtained from a real quantum device. however when using that noise model with a gate that is not native to the device the simulation, no noise gets added (e.g. #6607 (comment)). another issue is that when the circtuit uses qubits not on the device a key error is raised with little information explaining why that is.
Proposed Solution
Before (or while) running the simulation validate that the qubits and gets in the circuit uses supported qubits and gates.
How to reproduce the issue
#6607
Cirq version
1.4.0.dev20240419073809
The text was updated successfully, but these errors were encountered: