Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add very basic docker support #223

Closed
wants to merge 1 commit into from
Closed

Add very basic docker support #223

wants to merge 1 commit into from

Conversation

peauc
Copy link

@peauc peauc commented Jul 20, 2024

Fix #222

Add basic docker support for self hosted build


RUN go build

EXPOSE 8080
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default port for the server is 2221, and the alternative one is 8080. Is there any specific reason why only the latter is specified? The EXPOSE instruction is only informative but still.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During my tests i've found that I can connect to the chatroom using port 8080 so I replicated that in the dockerfile. I've spent no more than 15 minutes on the dockerfile + PR, no idea if other configurations works but interested in figuring it out

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a bunch of ports used. you'd probably want to expose the rpc one and also both the ssh ones. please have a look at the source

@Arkaeriit
Copy link
Collaborator

Devzat uses the file system to store ssh keys, server configuration, and user configuration. All those should be permanent after a Devzat restart. I am not a Docker expert but it looks like the files are erased after closing the docker container.

@quackduck
Copy link
Owner

What's the relationship here with the other docker pr?

@peauc
Copy link
Author

peauc commented Oct 5, 2024

@quackduck there is none, im closing this one

@peauc peauc closed this Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docker support
4 participants