Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace instrument settings #1090

Open
alecandido opened this issue Nov 1, 2024 · 0 comments
Open

Replace instrument settings #1090

alecandido opened this issue Nov 1, 2024 · 0 comments
Labels
Milestone

Comments

@alecandido
Copy link
Member

The .settings field of the Instrument abstract class is inherited by all instruments,

settings: Optional[InstrumentSettings] = None

but it is now inconsistent with our favored scheme of storing all configurations (including bounds) in the components' configs database.

Possibly for this reason, this attribute is disregarded by many instruments (starting with the dummy itself).

We should convert the few remaining instances making use of it (mostly LOs, or only those.) to the configs' layout.

@alecandido alecandido added this to the Qibolab 0.3.0 milestone Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant