Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple steering layout #69

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Simple steering layout #69

wants to merge 11 commits into from

Conversation

Alex-Walsh
Copy link
Contributor

@Alex-Walsh Alex-Walsh commented Jan 11, 2023

Ready for design review. The board shape needs to be changed (to fit the electronics) and I think some designators should be removed/ changed, just not sure which ones to do that to.

Copy link
Member

@ethanmpeterson ethanmpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's start with the layout checklist

Layout Checklist

  • No DRC errors => Still has 20 hole to hole distance errors. Otherwise looks really good!
  • All SMD parts on one layer
  • IR Calculations for high current traces
    The width should be large enough such that temperature increase for the expected current is no more than 5 to 10 degrees celsius
    => Going to waive this one, board is very low power.
  • Board is mechanically sound, dimensions are correct and component height does not create mechanical conflicts => This board does not need to fit on the car this year. If we end up using it in future, it would probably make sense to re do the layout to follow the steering package design.
  • IO ports and connectors double checked such that they are accessible when the board is fully assembled
    No unconnected ground (remove dead copper button checked on Altium polygon object or add stitching via)
  • Ground pour on top and bottom layers. => Let's add a top layer pour.
  • Stitching vias
  • Length matching for high speed signals and differential pairs => N/A
  • Proper filter capacitor placement for MCU layout (as close to the pin as possible and in the path of current flow) => I think most are good, will comment more below.

General Comments

  • No via sharing. each capacitor and resistor here should get their own via. This avoids coupling between the components and reduces the induction in the path to ground. Vias also don't cost us anything here, so might as well use them freely.
    image

  • Extend the polygon to wrap fully around the pad so it connects at all four points. I see a few other instances of this in the design as well. Do a quick check to correct any of them that you see
    image

  • Nitpick: clean up the edges
    image

  • we should widen up the thermal relief for 5V / GND power nets. I can show you how to do this.
    image

  • This is reset right? Name the net ATMEGA_RST_n or something readable
    image

  • 90 degree traces are sometimes ill advised because they can create acid traps. I don't think any of our fabs use this process but it is still one to avoid.
    image

  • This section can also be cleaned up a little bit, I would inline the resistor like so:
    image

  • I would also do something similar here:
    image
    image

  • Why this polygon cutout here?
    image

  • Also, it is good for digital signals with higher switching frequencies to place a GND via nearby to shorten the return path. Like so:
    image

  • Remember to add ground underneath for this to work

  • Avoid via sharing and via in pad
    image

  • Straighten out these polygon edges. clean up the capacitor connection
    image

  • Straighten out this edge and ensure the polygon connects on all four sides.
    image

  • Avoid shared vias
    image

  • Bring this via in closer the pad, longer trace = more inductance
    image

  • We wired this CAN termination resistor wrong. Should be bridging CAN_P/N
    image

  • Polygon cutout not needed.
    image
    image

  • Combine this, no need to swiss cheese it.
    image

  • These vias are floating. and should be removed. The ground pads are already connected in the ground plane. With the vias here, you are effectively asking them to drill an area that has already been drilled.
    image

  • Bring this via in:
    image

  • Silkscreen designator clean up required
    image

  • Remove this small kink in the SPI trace. Otherwise the routing for SPI looks great!
    image

  • Move this cap down a bit so it is directly in the path of current going into the ATMEGA 5V pin
    image

  • Bypass cap layout is good, but this would be an example of where you can just use a trace rather than a polygon
    image

@Alex-Walsh
Copy link
Contributor Author

changes have been made from the design review, I need help with some of the things on the checklist though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants