Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It adds the tag with a previous & symbol #20773

Closed
simonbcn opened this issue Apr 29, 2024 · 16 comments · Fixed by #21024
Closed

It adds the tag with a previous & symbol #20773

simonbcn opened this issue Apr 29, 2024 · 16 comments · Fixed by #21024
Assignees
Labels
Confirmed bug An issue confirmed by project team to be considered as a bug

Comments

@simonbcn
Copy link

qBittorrent & operating system versions

qBittorrent: 4.6.4 x64
Operating system: Arch Linux
Qt: 6.6.2
Libtorrent: 2.0.10.0
Boost: 1.83.0
OpenSSL: 3.2.1
zlib: 1.3.1

What is the problem?

When I add a torrent and tag it, it adds the tag with a previous & symbol.

image

Steps to reproduce

No response

Additional context

No response

Log(s) & preferences file(s)

No response

@glassez
Copy link
Member

glassez commented Apr 29, 2024

When I add a torrent and tag it

How exactly do you do this? (preferably with screenshots)

@simonbcn
Copy link
Author

Adding a .torrent file from qBittorrent:
Captura de pantalla_20240429_153642

Captura de pantalla_20240429_153657

@simonbcn
Copy link
Author

But if I add it from the webUI (I use VueTorrent) it does it correctly.

@glassez
Copy link
Member

glassez commented Apr 29, 2024

Do you create this tag just before assigning it or is it previously existing tag?
What is the value of Session\Tags setting under BitTorrent section of qBittorrent configuration file?

@qbittorrent/bug-handlers
Is anyone able to reproduce this?

@thalieht
Copy link
Contributor

@qbittorrent/bug-handlers
Is anyone able to reproduce this?

Not me.

@xavier2k6
Copy link
Member

xavier2k6 commented Apr 29, 2024

@qbittorrent/bug-handlers
Is anyone able to reproduce this?

Not me.

Me neither on windows

Ok, I've got something.....will explain later.

@xavier2k6 xavier2k6 added the Confirmed bug An issue confirmed by project team to be considered as a bug label Apr 29, 2024
@simonbcn
Copy link
Author

Do you create this tag just before assigning it or is it previously existing tag?

This occurs with both new and existing tags.

What is the value of Session\Tags setting under BitTorrent section of qBittorrent configuration file?

Session\Tags=redbits, qbittorrent tracker

@xavier2k6
Copy link
Member

Here you have two tags No. 1 = &redbits and No. 2 = redbits (What you don't see with 4.6.4 is that one of these has a shortcut key under the letter r due to the inclusion of the & symbol which you can see in master due to the change in style being used.)

image


Here, they are both being represented as redbits

Captura de pantalla_20240429_153642


In the WebUI, they are (from my testing) being displayed correctly ie &redbits / redbits

@xavier2k6
Copy link
Member

xavier2k6 commented Apr 29, 2024

@glassez @thalieht As you can see below, I made tags for &test / t&est / te&st / tes&t / test&

(4.6.4) Add Tag Window (All are displayed as test/indistinguishable)

Screenshot 2024-04-29 194516

(Master) Add Tag Window (All are distinguishable)

Screenshot 2024-04-29 195104


(4.6.4) Right-click Context Menu (All are displayed as test/indistinguishable)

Screenshot 2024-04-29 194602

(Master) Right-click Context Menu (All are distinguishable)

Screenshot 2024-04-29 195019


(4.6.4 WebUI) Right-click Context Menu (correctly reflects tag naming)

Screenshot 2024-04-29 194725

(Master WebUI) Right-click Context Menu (correctly reflects tag naming)

Screenshot 2024-04-29 195212

@glassez
Copy link
Member

glassez commented Apr 30, 2024

@xavier2k6
Good catch 👍
I began to suspect it too. But I was confused by the fact that @simonbcn did not mention (deliberately omitted?) that he created a tag with this symbol in it. According to him, it turned out that qBittorrent itself added this symbol to the tag, which did not contain it initially.

@simonbcn
Copy link
Author

@glassez I have not omitted anything. See video:
Videocaptura de pantalla_20240430_095131.webm

And this is the final Session\Tags:
Session\Tags=test, t&est, redbits, qbittorrent tracker

@xavier2k6
Copy link
Member

@simonbcn In your video, your 1st action shows that you mouse click ok but your 2nd action doesn't show any mouse click on ok when you added the test tag, did you use the keyboard?

@simonbcn
Copy link
Author

Let's see, it's very simple, I don't know why you make it so complicated. There is no need to add a new tag. In fact, I detected the problem when using a tag created a long time ago and that, until now, always worked correctly.
If, when adding a torrent, from the qBittorrent application, I assign a label (previously created or new) it adds a & symbol, although not always in the same place.
If I use redbits it converts it to &redbits. If I create test and use it later, it converts it to t&est. Creating a new tag with that symbol inserted.

If I add the same torrent with the same tag from the webUI (VueTorrent) it works correctly.

@simonbcn
Copy link
Author

simonbcn commented May 1, 2024

I have recompiled the Arch Linux package and the problem persists.

@simonbcn
Copy link
Author

simonbcn commented Jul 3, 2024

Any progress with this issue? I can't use the application when I want to use tags.

@glassez
Copy link
Member

glassez commented Jul 4, 2024

Could you test #21024?

@glassez glassez self-assigned this Jul 4, 2024
glassez added a commit to glassez/qBittorrent that referenced this issue Jul 5, 2024
glassez added a commit that referenced this issue Jul 7, 2024
glassez added a commit to glassez/qBittorrent that referenced this issue Jul 7, 2024
glassez added a commit to sledgehammer999/qBittorrent that referenced this issue Jul 7, 2024
glassez added a commit to glassez/qBittorrent that referenced this issue Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Confirmed bug An issue confirmed by project team to be considered as a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants