Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grid size is not adjusted to grid content #112

Open
jenniferboedker opened this issue Sep 27, 2021 · 0 comments
Open

Grid size is not adjusted to grid content #112

jenniferboedker opened this issue Sep 27, 2021 · 0 comments
Assignees
@jenniferboedker
Labels
enhancement New feature or request
Milestone
Beta Release

Comments

@jenniferboedker
Copy link
Contributor

jenniferboedker commented Sep 27, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
The grid size seems to be fixed and is not responsive to the grid content. This results in the grid being bigger than its actual content (see screenshot)

Describe the solution you'd like
The grid size should be responsive to its content

Screenshot 2021-09-27 at 16 19 58

Pay attention to the right end of the grid.
@jenniferboedker jenniferboedker added the enhancement New feature or request label Sep 27, 2021
@jenniferboedker jenniferboedker added this to the Beta Release milestone Sep 27, 2021
@KochTobi KochTobi self-assigned this Oct 1, 2021
@jenniferboedker jenniferboedker mentioned this issue Oct 11, 2021
Merged
@Steffengreiner Steffengreiner mentioned this issue Feb 8, 2022
Merged
sven1103 pushed a commit that referenced this issue Feb 11, 2022
@Steffengreiner
Add responsive project grid (#218)
0306a37 
Description of changes
Addresses #112 by introducing a columnresize listener which adapts the projectGrid width to the set column size.
Also adjusts css to set minimum-width for individual columns.
Finally introduces breakpoints to resize projecttitle column if screen is too small for entire grid

Technical Details
Apparently Vaadin 8 doesn't allow for adding styles to an already styled component, therefore the styling of the components of the projectgrid had to be centralised.
Also manual resizing of a column should actually be discouraged since it's disables the automatic size calculation from vaadin. See response by Henri Sara in this thread.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jenniferboedker jenniferboedker

Labels
enhancement New feature or request
Projects
None yet
Milestone
Beta Release
Development

No branches or pull requests
2 participants
@KochTobi @jenniferboedker