Skip to content

Commit

Permalink
Fix publication of ROCm wheels (pytorch#2052)
Browse files Browse the repository at this point in the history
Summary:
Move Nova ROCm jobs into the same workflow file to prevent incorrect publication of ROCm wheels

Separating build_wheels_linux.yml for rocm causes rocm wheels to be uploaded into the wrong folder on pytorch.org.

On Nova, when publishing with one architecture, it pushes wheels to nightly/ rather than a specific architecure. pip fetches that nightly regardless of the underlying architecture.  When publishing with multiple architectures, it uploads to the architecture-specific folder under nightly (e.g., cpu, cu118, rocm5.5).

Pull Request resolved: pytorch#2052

Reviewed By: spcyppt

Differential Revision: D49760071

Pulled By: q10

fbshipit-source-id: 34abb06cdcd0a294ff7a5937fdb966b204c3b717
  • Loading branch information
q10 authored and facebook-github-bot committed Sep 29, 2023
1 parent 32c969f commit d1b8766
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 53 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build_wheels_linux_x86.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
test-infra-repository: pytorch/test-infra
test-infra-ref: main
with-cuda: enable
with-rocm: disable
with-rocm: enable
with-cpu: enable
build:
needs: generate-matrix
Expand Down
52 changes: 0 additions & 52 deletions .github/workflows/build_wheels_linux_x86_rocm.yml

This file was deleted.

0 comments on commit d1b8766

Please sign in to comment.