From 95a3f2f6f76b9d9442759a41a61e02b636038d0a Mon Sep 17 00:00:00 2001 From: Benson Ma Date: Mon, 26 Feb 2024 11:21:49 -0800 Subject: [PATCH] [fbgemm_gpu] Fix mpmath dependency - Fix mpmath dependency to allow tests to pass again; see https://github.com/jianyicheng/mase-docker/pull/9 https://github.com/nod-ai/SHARK/issues/2095 --- .github/scripts/utils_build.bash | 8 +++++--- docs/requirements.txt | 6 ++++++ fbgemm_gpu/docs/requirements.txt | 6 ++++++ fbgemm_gpu/requirements.txt | 13 +++++++++++++ 4 files changed, 30 insertions(+), 3 deletions(-) diff --git a/.github/scripts/utils_build.bash b/.github/scripts/utils_build.bash index 6d825a0fe0..3ea84ce03a 100644 --- a/.github/scripts/utils_build.bash +++ b/.github/scripts/utils_build.bash @@ -247,9 +247,11 @@ install_build_tools () { echo "[INSTALL] Installing build tools ..." # NOTES: - # - Only the openblas package will install cblas.h directly into - # $CONDA_PREFIX/include directory - # - ncurses is needed to silence bad libtinfo6.so errors for ROCm+Clang builds + # + # - Only the openblas package will install directly into + # $CONDA_PREFIX/include directory, which is required for FBGEMM tests + # + # - ncurses is needed to silence libtinfo6.so errors for ROCm+Clang builds # # shellcheck disable=SC2086 (exec_with_retries 3 conda install ${env_prefix} -c conda-forge -y \ diff --git a/docs/requirements.txt b/docs/requirements.txt index c6d34064aa..c0a3144411 100644 --- a/docs/requirements.txt +++ b/docs/requirements.txt @@ -1,2 +1,8 @@ +# Copyright (c) Meta Platforms, Inc. and affiliates. +# All rights reserved. +# +# This source code is licensed under the BSD-style license found in the +# LICENSE file in the root directory of this source tree. + breathe sphinx_rtd_theme diff --git a/fbgemm_gpu/docs/requirements.txt b/fbgemm_gpu/docs/requirements.txt index f62b11dae9..9f3bca4399 100644 --- a/fbgemm_gpu/docs/requirements.txt +++ b/fbgemm_gpu/docs/requirements.txt @@ -1,3 +1,9 @@ +# Copyright (c) Meta Platforms, Inc. and affiliates. +# All rights reserved. +# +# This source code is licensed under the BSD-style license found in the +# LICENSE file in the root directory of this source tree. + # Note: Sphinx 7+ currently runs into an `Undefinederror("'style' is undefined")` # We should eventually move to Sphinx 7+ to resolve # https://github.com/sphinx-doc/sphinx/issues/1514 diff --git a/fbgemm_gpu/requirements.txt b/fbgemm_gpu/requirements.txt index 0e06a77a43..f85b60da58 100644 --- a/fbgemm_gpu/requirements.txt +++ b/fbgemm_gpu/requirements.txt @@ -1,6 +1,19 @@ +# Copyright (c) Meta Platforms, Inc. and affiliates. +# All rights reserved. +# +# This source code is licensed under the BSD-style license found in the +# LICENSE file in the root directory of this source tree. + +# NOTES: +# +# - A fixed version of mpmath is needed to work around an AttributeError; see: +# * https://github.com/nod-ai/SHARK/issues/2095 +# * https://github.com/jianyicheng/mase-docker/pull/9 + cmake hypothesis jinja2 +mpmath==1.3.0 ninja numpy scikit-build