Skip to content

Commit

Permalink
Mark some more ops as pt2_compliant_tag (pytorch#2171)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: pytorch#2171

Also deleted two skips that were marked as flaky. Those don't appear to
actually be flaky.

Reviewed By: williamwen42

Differential Revision: D51647391

fbshipit-source-id: 4c70558e2e6d4cb7d2c8566e40f5da06050681d4
  • Loading branch information
zou3519 authored and facebook-github-bot committed Nov 29, 2023
1 parent 71e496a commit 90bb32d
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 15 deletions.
9 changes: 6 additions & 3 deletions fbgemm_gpu/src/sparse_ops/sparse_ops_cpu.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2730,12 +2730,15 @@ TORCH_LIBRARY_FRAGMENT(fbgemm, m) {
m.def(
"permute_sparse_data(Tensor permute, Tensor lengths, Tensor values, Tensor? weights=None, SymInt? permuted_lengths_sum=None) -> (Tensor, Tensor, Tensor?)");
m.def(
"permute_2D_sparse_data(Tensor permute, Tensor lengths, Tensor values, Tensor? weights=None, SymInt? permuted_lengths_sum=None) -> (Tensor, Tensor, Tensor?)");
"permute_2D_sparse_data(Tensor permute, Tensor lengths, Tensor values, Tensor? weights=None, SymInt? permuted_lengths_sum=None) -> (Tensor, Tensor, Tensor?)",
{PT2_COMPLIANT_TAG});
m.def(
"permute_1D_sparse_data(Tensor permute, Tensor lengths, Tensor values, Tensor? weights=None, SymInt? permuted_lengths_sum=None) -> (Tensor, Tensor, Tensor?)");
"permute_1D_sparse_data(Tensor permute, Tensor lengths, Tensor values, Tensor? weights=None, SymInt? permuted_lengths_sum=None) -> (Tensor, Tensor, Tensor?)",
{PT2_COMPLIANT_TAG});
m.def("invert_permute(Tensor permute) -> Tensor");
m.def(
"expand_into_jagged_permute(Tensor permute, Tensor input_offset, Tensor output_offset, SymInt output_size) -> Tensor");
"expand_into_jagged_permute(Tensor permute, Tensor input_offset, Tensor output_offset, SymInt output_size) -> Tensor",
{PT2_COMPLIANT_TAG});
m.def(
"block_bucketize_sparse_features(Tensor lengths, Tensor indices, bool bucketize_pos, bool sequence, Tensor block_sizes, SymInt my_size, Tensor? weights=None, Tensor? batch_size_per_feature=None, SymInt max_B= -1, Tensor[]? block_bucketize_pos=None) -> (Tensor, Tensor, Tensor?, Tensor?, Tensor?)");
m.def(
Expand Down
14 changes: 2 additions & 12 deletions fbgemm_gpu/test/failures_dict.json
Original file line number Diff line number Diff line change
Expand Up @@ -436,18 +436,8 @@
"status": "xfail"
}
},
"fbgemm::permute_1D_sparse_data": {
"SparseOpsTest.test_schema__test_permute_indices": {
"comment": "flaky",
"status": "skip"
}
},
"fbgemm::permute_2D_sparse_data": {
"SparseOpsTest.test_schema__test_permute_indices": {
"comment": "flaky",
"status": "skip"
}
},
"fbgemm::permute_1D_sparse_data": {},
"fbgemm::permute_2D_sparse_data": {},
"fbgemm::permute_sequence_embeddings": {
"SparseOpsTest.test_aot_dispatch_dynamic__test_permute_embeddings": {
"comment": "",
Expand Down

0 comments on commit 90bb32d

Please sign in to comment.