Skip to content

Commit

Permalink
Fix package version logic (pytorch#2048)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: pytorch#2048

- Fix package version logic
- Change default package variant to cuda
- Fix rocm variants for testing (rocm versions on Nova are 5.6 and 5.7)

Reviewed By: sryap

Differential Revision: D49740927

fbshipit-source-id: 870812fd46dbd3e5e2765540b94fb45951811a8f
  • Loading branch information
spcyppt authored and facebook-github-bot committed Sep 28, 2023
1 parent 1595e2a commit 7c9e21d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/fbgemm_gpu_pip.yml
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ jobs:
]
# ROCm machines are limited, so we only test against Python 3.10
python-version: [ "3.10" ]
rocm-version: [ "5.5.1", "5.6" ]
rocm-version: [ "5.6", "5.7" ]

steps:
- name: Setup Build Container
Expand Down
4 changes: 2 additions & 2 deletions fbgemm_gpu/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def parse_args(argv: List[str]) -> argparse.Namespace:
"--package_variant",
type=str,
choices=["cpu", "cuda", "rocm"],
default="cpu",
default="cuda",
help="The FBGEMM_GPU variant to build.",
)
parser.add_argument(
Expand Down Expand Up @@ -344,7 +344,7 @@ def main(argv: List[str]) -> None:

# Generate the full package version string
package_version = FbgemmGpuInstaller.generate_package_version(
package_name, variant_version
args.package_name, variant_version
)

# Generate the version file
Expand Down

0 comments on commit 7c9e21d

Please sign in to comment.