Deprecate GPU approx_rowwise_adagrad_with_weight_decay (pytorch#2253)

Summary: Pull Request resolved: pytorch#2253 Deprecate `approx_rowwise_adagrad_with_weight_decay` GPU kernel Reviewed By: sryap Differential Revision: D52574861 fbshipit-source-id: 4356a32dab3421f434847b4d5df5b8c40f37a725
q10 · Jan 8, 2024 · 638e833 · 638e833
1 parent 569ca7e
commit 638e833
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/fbgemm_gpu/CMakeLists.txt b/fbgemm_gpu/CMakeLists.txt
@@ -182,13 +182,13 @@ set(GPU_ONLY_OPTIMIZERS
   partial_rowwise_adam
   partial_rowwise_lamb
   lars_sgd
-  approx_rowwise_adagrad_with_weight_decay
   none)
 
 set(DEPRECATED_OPTIMIZERS
   approx_sgd
   approx_rowwise_adagrad
   approx_rowwise_adagrad_with_counter
+  approx_rowwise_adagrad_with_weight_decay
   rowwise_adagrad_with_weight_decay)
 
 set(ALL_OPTIMIZERS

diff --git a/fbgemm_gpu/codegen/embedding_common_code_generator.py b/fbgemm_gpu/codegen/embedding_common_code_generator.py
@@ -711,6 +711,7 @@ def rowwise_adagrad_with_weight_decay() -> Dict[str, Any]:
     }
 
 
+# Deprecated, to be cleaned up
 def approx_rowwise_adagrad_with_weight_decay() -> Dict[str, Any]:
     rowwise_adagrad_with_weight_decay_args = rowwise_adagrad_with_weight_decay()
 
@@ -740,7 +741,7 @@ def approx_rowwise_adagrad_with_weight_decay() -> Dict[str, Any]:
             "split_weight_update_cpu"
         ],
         "has_cpu_support": False,
-        "has_gpu_support": True,
+        "has_gpu_support": False,
         "has_vbe_support": False,
     }