-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation: Fix ptp --> np.ptp for numpy 2.0.0 #228
Conversation
…precationsWarning
@hakonanes If you want to review/merge this I can start the process of making a numpy 2.0.0 patch release. |
@@ -5,6 +5,11 @@ | |||
|
|||
from diffsims.utils._deprecated import deprecated, deprecated_argument | |||
|
|||
if np.__version__ >= "2.0.0": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of repeating this three places, I suggest to add a private diffsims.constants
module like we've done in orix: https://github.com/pyxem/orix/blob/develop/orix/constants.py. We can then import this warning from diffsims.constants import VisibleDeprecationWarning
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor suggestions. Not required for merging.
Description of the change
Support numpy 2.0.0
Progress of the PR
For reviewers
__init__.py
.unreleased section in
CHANGELOG.rst
.credits
indiffsims/release_info.py
andin
.zenodo.json
.