Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use external libdatrie #56

Open
dmacks opened this issue Oct 28, 2018 · 0 comments
Open

Use external libdatrie #56

dmacks opened this issue Oct 28, 2018 · 0 comments

Comments

@dmacks
Copy link

dmacks commented Oct 28, 2018

Building 0.7.1 on my OS X 10.13 machine, I instrumented the build and see that both stages of the compiling (the internal libdatrie and the python glue code) are actually using the libdatrie headers installed elsewhere on my system. But then linking the glue code uses the internal liblibdatrie.a. Why does this python package include its own copy of libdatrie at all instead of using it externally installed on the system? Seems like extra effort to keep it in sync (and patch), and now we see there is a need to hack on setuputils's flag passing problem. See for example https://salsa.debian.org/python-team/modules/python-datrie/blob/master/debian/patches/0002-Don-t-use-bundled-libdatrie.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant