-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a GitHub Action to run Packer builds for Windows AMI #5992
Comments
This task will require more infrastructure setup than I initially thought. So the current ALI system deployed in PyTorch Foundation's AWS Account is a repository level ALI deployment so it only works with |
Looks like we need to create some sort of policies thru AWS accounts to allow both account push AMIs |
Originally I was thinking that we'd run 2 jobs one on Meta and one on LF side to push the AMI automatically. But on the CI Sync meeting today there were a few other suggestions.
I think all of these options will work however option 2 is probably the simplest solution since Meta runners are already setup to work on pytorch/test-infra and would only require the sharing of AMI to the LF Account. If we agree to go with option 2 then I think I can start working on this task to create a job to build the AMI in Meta's AWS Account and someone from Meta can setup the AMI sharing permissions with the LF account. @atalman @ZainRizvi any opinions on which option you want to go with? |
This role allows Packer to run `packer build` to create AMIs. Issue: pytorch/test-infra#5992 Signed-off-by: Thanh Ha <[email protected]>
Okay so I realized I could create the job on pytorch/pytorch and have it fetch test-infra before running packer build. This will allow us to just build the AMI directly in the PyTorch AWS Account. I think we should build there so that it's done on the community side and we can share the AMI back to Meta's CI account. This ci-infra PR pytorch/ci-infra#312 is ready to go. I've confirmed the permissions work to allow GHA to run packer build. I'm currently testing pytorch/pytorch#143132 which adds the job in pytorch/pytorch and will update once I've confirmed it to be working and can successfully create the AMI. |
This role allows Packer to run `packer build` to create AMIs. Issue: pytorch/test-infra#5992 Signed-off-by: Thanh Ha <[email protected]>
This role allows Packer to run `packer build` to create AMIs. Issue: pytorch/test-infra#5992 Signed-off-by: Thanh Ha <[email protected]>
Add a job to create Windows AMIs in the PyTorch AWS Account. Issue: pytorch/test-infra#5992 Signed-off-by: Thanh Ha <[email protected]>
Add a job to create Windows AMIs in the PyTorch AWS Account. Issue: pytorch/test-infra#5992 Signed-off-by: Thanh Ha <[email protected]>
Add a job to create Windows AMIs in the PyTorch AWS Account. Issue: pytorch/test-infra#5992 Signed-off-by: Thanh Ha <[email protected]>
I was able to create a job that uses |
Add a job to create Windows AMIs in the PyTorch AWS Account. Issue: #5992 Signed-off-by: Thanh Ha <[email protected]>
Add a job to create Windows AMIs in the PyTorch AWS Account. Issue: #5992 Signed-off-by: Thanh Ha <[email protected]>
Add a job to create Windows AMIs in the PyTorch AWS Account. Issue: #5992 Signed-off-by: Thanh Ha <[email protected]>
Add a job to create Windows AMIs in the PyTorch AWS Account. Issue: #5992 Signed-off-by: Thanh Ha <[email protected]>
Allow the pytorch/test-infra repo to be able to use the packer role. Issue: pytorch/test-infra#5992 Signed-off-by: Thanh Ha <[email protected]>
Add a job to create Windows AMIs in the PyTorch AWS Account. Issue: #5992 Signed-off-by: Thanh Ha <[email protected]>
Allow the pytorch/test-infra repo to be able to use the packer role. Issue: pytorch/test-infra#5992 Signed-off-by: Thanh Ha <[email protected]>
Allow the pytorch/test-infra repo to be able to use the packer role. Issue: pytorch/test-infra#5992 Signed-off-by: Thanh Ha <[email protected]>
Add a job to create Windows AMIs in the PyTorch AWS Account. Issue: #5992 --------- Signed-off-by: Thanh Ha <[email protected]>
Currently the Windows AMI is being manually created and uploaded to both Meta and PyTorch Foundation AWS accounts. Instead we should utilize GitHub Actions to create a publish job that can handle this automatically for us.
The text was updated successfully, but these errors were encountered: