Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[log classifier] docs build: there is a better line #5975

Open
clee2000 opened this issue Nov 22, 2024 · 1 comment
Open

[log classifier] docs build: there is a better line #5975

clee2000 opened this issue Nov 22, 2024 · 1 comment
Assignees

Comments

@clee2000
Copy link
Contributor

https://github.com/pytorch/pytorch/actions/runs/11980936976/job/33406870951

Currently pointing to

2024-11-22T22:42:44.8479717Z /opt/conda/envs/py_3.9/lib/python3.9/site-packages/sphinx/util/inspect.py:376: UserWarning: TypedStorage is deprecated. It will be removed in the future and UntypedStorage will be the only storage class. This should only matter to you if you are using storages directly.  To access UntypedStorage directly, use tensor.untyped_storage() instead of tensor.storage()

but https://github.com/pytorch/pytorch/actions/runs/11980936976/job/33406870951#step:11:1348 would be better

You added the following module(s) to the PyTorch namespace 'torch.fx.experimental.constant_symnode' but they have no corresponding entry in a doc .rst file. You should either make sure that the .rst file that contains the module's documentation properly contains either '.. automodule:: mod_name' (if you do not want the paragraph added by the automodule, you can simply use '.. py:module:: mod_name')  or make the module private (by appending an '_' at the beginning of its name).+ echo 'Make sure you'\''ve updated relevant .rsts in docs/source!'
Make sure you've updated relevant .rsts in docs/source!
@ZainRizvi ZainRizvi self-assigned this Dec 3, 2024
@ZainRizvi ZainRizvi moved this to Prioritized in PyTorch OSS Dev Infra Dec 3, 2024
@ZainRizvi
Copy link
Contributor

cc: @wdvr fyi

ZainRizvi added a commit that referenced this issue Dec 11, 2024
Mitigates #5975

A better (but more involved) fix will be to update the AI part of log
classifier to better notice that this line was the real failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Prioritized
Development

No branches or pull requests

2 participants