Enable VBE support on CPU #3174
Open
+259
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D63410944 |
|
This pull request was exported from Phabricator. Differential Revision: D63410944 |
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Sep 25, 2024
Summary: Pull Request resolved: pytorch#3174 Previous VBE on CPU was enabled in lookup_{{ optimizer }}.py. To support MTIA ops, VBE should be done after torch.ops.fbgemm.{{ mdesc }}_embedding_codegen_lookup_{{ optimizer }}_function_pt2. This diff follows the same implementation but enables it C++ so that it goes through the same PT2 pipeline (i.e., lookup -> VBE autograd -> cpu wrapper (*do vbe here*) -> cpu kernel). the call is done Differential Revision: D63410944
spcyppt
force-pushed
the
export-D63410944
branch
from
555d40f
to
4fd9e29
Compare
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Sep 25, 2024
Summary: Pull Request resolved: pytorch#3174 Previous VBE on CPU was enabled in lookup_{{ optimizer }}.py. To support MTIA ops, VBE should be done after torch.ops.fbgemm.{{ mdesc }}_embedding_codegen_lookup_{{ optimizer }}_function_pt2. This diff follows the same implementation but enables it C++ so that it goes through the same PT2 pipeline (i.e., lookup -> VBE autograd -> cpu wrapper (*do vbe here*) -> cpu kernel). the call is done Differential Revision: D63410944
spcyppt
force-pushed
the
export-D63410944
branch
from
4fd9e29
to
931fe2f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63410944 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D63410944 |
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Sep 25, 2024
Summary: Pull Request resolved: pytorch#3174 Previous VBE on CPU was enabled in lookup_{{ optimizer }}.py. To support MTIA ops, VBE should be done after torch.ops.fbgemm.{{ mdesc }}_embedding_codegen_lookup_{{ optimizer }}_function_pt2. This diff follows the same implementation but enables it C++ so that it goes through the same PT2 pipeline (i.e., lookup -> VBE autograd -> cpu wrapper (*do vbe here*) -> cpu kernel). the call is done Differential Revision: D63410944
spcyppt
force-pushed
the
export-D63410944
branch
from
931fe2f
to
a60eb2e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63410944 |
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Sep 26, 2024
Summary: Pull Request resolved: pytorch#3174 Previous VBE on CPU was enabled in lookup_{{ optimizer }}.py. To support MTIA ops, VBE should be done after torch.ops.fbgemm.{{ mdesc }}_embedding_codegen_lookup_{{ optimizer }}_function_pt2. This diff follows the same implementation but enables it C++ so that it goes through the same PT2 pipeline (i.e., lookup -> VBE autograd -> cpu wrapper (*do vbe here*) -> cpu kernel). the call is done Differential Revision: D63410944
spcyppt
force-pushed
the
export-D63410944
branch
from
a60eb2e
to
c56c9b4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63410944 |
spcyppt
force-pushed
the
export-D63410944
branch
from
c56c9b4
to
2b74f69
Compare
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Sep 26, 2024
Summary: Pull Request resolved: pytorch#3174 Previous VBE on CPU was enabled in lookup_{{ optimizer }}.py. To support MTIA ops, VBE should be done after torch.ops.fbgemm.{{ mdesc }}_embedding_codegen_lookup_{{ optimizer }}_function_pt2. This diff follows the same implementation but enables it C++ so that it goes through the same PT2 pipeline (i.e., lookup -> VBE autograd -> cpu wrapper (*do vbe here*) -> cpu kernel). the call is done Differential Revision: D63410944
|
This pull request was exported from Phabricator. Differential Revision: D63410944 |
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Sep 26, 2024
Summary: Pull Request resolved: pytorch#3174 Previous VBE on CPU was enabled in lookup_{{ optimizer }}.py. To support MTIA ops, VBE should be done after torch.ops.fbgemm.{{ mdesc }}_embedding_codegen_lookup_{{ optimizer }}_function_pt2. This diff follows the same implementation but enables it C++ so that it goes through the same PT2 pipeline (i.e., lookup -> VBE autograd -> cpu wrapper (*do vbe here*) -> cpu kernel). the call is done Differential Revision: D63410944
spcyppt
force-pushed
the
export-D63410944
branch
from
2b74f69
to
79cc1d8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63410944 |
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Sep 26, 2024
Summary: Pull Request resolved: pytorch#3174 Previous VBE on CPU was enabled in lookup_{{ optimizer }}.py. To support MTIA ops, VBE should be done after torch.ops.fbgemm.{{ mdesc }}_embedding_codegen_lookup_{{ optimizer }}_function_pt2. This diff follows the same implementation but enables it C++ so that it goes through the same PT2 pipeline (i.e., lookup -> VBE autograd -> cpu wrapper (*do vbe here*) -> cpu kernel). the call is done Differential Revision: D63410944
spcyppt
force-pushed
the
export-D63410944
branch
from
79cc1d8
to
b16c1e6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63410944 |
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Sep 27, 2024
Summary: Pull Request resolved: pytorch#3174 Previous VBE on CPU was enabled in lookup_{{ optimizer }}.py. To support MTIA ops, VBE should be done after torch.ops.fbgemm.{{ mdesc }}_embedding_codegen_lookup_{{ optimizer }}_function_pt2. This diff follows the same implementation but enables it C++ so that it goes through the same PT2 pipeline (i.e., lookup -> VBE autograd -> cpu wrapper (*do vbe here*) -> cpu kernel). the call is done Reviewed By: q10 Differential Revision: D63410944
spcyppt
force-pushed
the
export-D63410944
branch
from
b16c1e6
to
2be8b61
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63410944 |
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Sep 27, 2024
Summary: Pull Request resolved: pytorch#3174 Previous VBE on CPU was enabled in lookup_{{ optimizer }}.py. To support MTIA ops, VBE should be done after torch.ops.fbgemm.{{ mdesc }}_embedding_codegen_lookup_{{ optimizer }}_function_pt2. This diff follows the same implementation but enables it C++ so that it goes through the same PT2 pipeline (i.e., lookup -> VBE autograd -> cpu wrapper (*do vbe here*) -> cpu kernel). the call is done Reviewed By: q10 Differential Revision: D63410944
spcyppt
force-pushed
the
export-D63410944
branch
2 times, most recently
from
8c4f8f5
to
b2c45b5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63410944 |
Summary: Pull Request resolved: pytorch#3174 Previous VBE on CPU was enabled in lookup_{{ optimizer }}.py. To support MTIA ops, VBE should be done after torch.ops.fbgemm.{{ mdesc }}_embedding_codegen_lookup_{{ optimizer }}_function_pt2. This diff follows the same implementation but enables it C++ so that it goes through the same PT2 pipeline (i.e., lookup -> VBE autograd -> cpu wrapper (*do vbe here*) -> cpu kernel). the call is done Reviewed By: q10 Differential Revision: D63410944
spcyppt
force-pushed
the
export-D63410944
branch
from
b2c45b5
to
a508722
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63410944 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previous VBE on CPU was enabled in lookup_{{ optimizer }}.py.
To support MTIA ops, VBE should be done after torch.ops.fbgemm.{{ mdesc }}embedding_codegen_lookup{{ optimizer }}_function_pt2.
This diff follows the same implementation but enables it C++ so that it goes through the same PT2 pipeline (i.e., lookup -> VBE autograd -> cpu wrapper (do vbe here) -> cpu kernel). the call is done
Differential Revision: D63410944