Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errant rpath in binaries #3098

Open
isuruf opened this issue Sep 9, 2024 · 1 comment
Open

Errant rpath in binaries #3098

isuruf opened this issue Sep 9, 2024 · 1 comment

Comments

@isuruf
Copy link

isuruf commented Sep 9, 2024

For eg: there's an rpath /__w/_temp/conda_environment_10143495636/lib.

This can be a security issue if a user has access to /__w, but is not the norm in a normal unix layout

$ readelf -d /home/isuruf/.conda/envs/pytorch-dev/lib/python3.8/site-packages/fbgemm_gpu/fbgemm_gpu_py.so

Dynamic section at offset 0x579705e0 contains 41 entries:
  Tag        Type                         Name/Value
 0x0000000000000001 (NEEDED)             Shared library: [libtorch.so]
 0x0000000000000001 (NEEDED)             Shared library: [libc10.so]
 0x0000000000000001 (NEEDED)             Shared library: [libc10_cuda.so]
 0x0000000000000001 (NEEDED)             Shared library: [libnvidia-ml.so.1]
 0x0000000000000001 (NEEDED)             Shared library: [libtorch_cpu.so]
 0x0000000000000001 (NEEDED)             Shared library: [libtorch_cuda.so]
 0x0000000000000001 (NEEDED)             Shared library: [libcudart.so.12]
 0x0000000000000001 (NEEDED)             Shared library: [librt.so.1]
 0x0000000000000001 (NEEDED)             Shared library: [libpthread.so.0]
 0x0000000000000001 (NEEDED)             Shared library: [libstdc++.so.6]
 0x0000000000000001 (NEEDED)             Shared library: [libm.so.6]
 0x0000000000000001 (NEEDED)             Shared library: [libgcc_s.so.1]
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.6]
 0x0000000000000001 (NEEDED)             Shared library: [ld-linux-x86-64.so.2]
 0x000000000000000f (RPATH)              Library rpath: [/__w/_temp/conda_environment_10143495636/lib]
@q10
Copy link
Contributor

q10 commented Sep 9, 2024

Hi @isuruf thanks for reporting this. We will work to remove this rpath from the binary.

q10 added a commit to q10/FBGEMM that referenced this issue Sep 23, 2024
- Remove errant RPATHs from binaries (pytorch#3098)
q10 added a commit to q10/FBGEMM that referenced this issue Sep 23, 2024
- Remove errant RPATHs from binaries (pytorch#3098)
q10 added a commit to q10/FBGEMM that referenced this issue Sep 23, 2024
- Remove errant RPATHs from binaries (pytorch#3098)
q10 added a commit to q10/FBGEMM that referenced this issue Sep 23, 2024
- Remove errant RPATHs from binaries (pytorch#3098)
q10 added a commit to q10/FBGEMM that referenced this issue Sep 23, 2024
- Remove errant RPATHs from binaries (pytorch#3098)
q10 added a commit to q10/FBGEMM that referenced this issue Sep 23, 2024
- Remove errant RPATHs from binaries (pytorch#3098)
q10 added a commit to q10/FBGEMM that referenced this issue Sep 23, 2024
- Remove errant RPATHs from binaries (pytorch#3098)
q10 added a commit to q10/FBGEMM that referenced this issue Sep 23, 2024
- Remove errant RPATHs from binaries (pytorch#3098)
q10 added a commit to q10/FBGEMM that referenced this issue Sep 23, 2024
- Remove errant RPATHs from binaries (pytorch#3098)
q10 added a commit to q10/FBGEMM that referenced this issue Sep 23, 2024
- Remove errant RPATHs from binaries (pytorch#3098)
q10 added a commit to q10/FBGEMM that referenced this issue Sep 23, 2024
- Remove errant RPATHs from binaries (pytorch#3098)
q10 added a commit to q10/FBGEMM that referenced this issue Sep 23, 2024
- Remove errant RPATHs from binaries (pytorch#3098)
q10 added a commit to q10/FBGEMM that referenced this issue Sep 23, 2024
- Remove errant RPATHs from binaries (pytorch#3098)
q10 added a commit to q10/FBGEMM that referenced this issue Sep 23, 2024
- Remove errant RPATHs from binaries (pytorch#3098)
q10 added a commit to q10/FBGEMM that referenced this issue Sep 23, 2024
- Remove errant RPATHs from binaries (pytorch#3098)
q10 added a commit to q10/FBGEMM that referenced this issue Sep 23, 2024
- Remove errant RPATHs from binaries (pytorch#3098)
q10 added a commit to q10/FBGEMM that referenced this issue Sep 23, 2024
- Remove errant RPATHs from binaries (pytorch#3098)
q10 added a commit to q10/FBGEMM that referenced this issue Sep 23, 2024
- Remove errant RPATHs from binaries (pytorch#3098)
q10 added a commit to q10/FBGEMM that referenced this issue Sep 23, 2024
- Remove errant RPATHs from binaries (pytorch#3098)
q10 added a commit to q10/FBGEMM that referenced this issue Sep 23, 2024
- Remove errant RPATHs from binaries (pytorch#3098)
q10 added a commit to q10/FBGEMM that referenced this issue Sep 23, 2024
- Remove errant RPATHs from binaries (pytorch#3098)
q10 added a commit to q10/FBGEMM that referenced this issue Sep 23, 2024
- Remove errant RPATHs from binaries (pytorch#3098)
q10 added a commit to q10/FBGEMM that referenced this issue Sep 24, 2024
Summary:
X-link: facebookresearch/FBGEMM#261

- Remove errant RPATHs from binaries (pytorch#3098)

Pull Request resolved: pytorch#3163

Reviewed By: basilwong

Differential Revision: D63294995

Pulled By: q10
facebook-github-bot pushed a commit that referenced this issue Sep 25, 2024
Summary:
X-link: facebookresearch/FBGEMM#261

- Remove errant RPATHs from binaries (#3098)

Pull Request resolved: #3163

Reviewed By: basilwong

Differential Revision: D63294995

Pulled By: q10

fbshipit-source-id: a104c5958ba0d4caa954155aae898cda703943ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants