Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fbgemm_gpu doesn't build for CPU because impl_abstract_pystub is not found #2362

Open
gshimansky opened this issue Feb 27, 2024 · 1 comment

Comments

@gshimansky
Copy link

I am trying to build fbgemm_gpu for CPU and when I build it I am getting an compilation error that impl_abstract_pystub is not found in line jagged_tensor_ops_cpu.cpp:1661. Looking at the source code https://github.com/pytorch/FBGEMM/blob/main/fbgemm_gpu/src/jagged_tensor_ops/jagged_tensor_ops_cpu.cpp#L1661-L1663 and in all other places where impl_abstract_pystub is used in fbgemm_gpu it seems to be that this call should exist only under HAS_IMPL_ABSTRACT_PYSTUB condition. In this place the same code is copied outside of this condition. Should it be deleted?

@q10
Copy link
Contributor

q10 commented Feb 27, 2024

Hi @gshimansky, thanks for pointing out the bug. This is being addressed in #2363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants