From b9dc5ec51db9a04f5474ec399a217b817edd5279 Mon Sep 17 00:00:00 2001 From: Benson Ma Date: Mon, 23 Sep 2024 11:48:28 -0700 Subject: [PATCH] [fbgemm_gpu] Remove errant RPATHs from binaries - Remove errant RPATHs from binaries (https://github.com/pytorch/FBGEMM/issues/3098) --- .github/scripts/fbgemm_gpu_build.bash | 3 +++ .github/scripts/utils_build.bash | 1 + fbgemm_gpu/CMakeLists.txt | 4 ++++ 3 files changed, 8 insertions(+) diff --git a/.github/scripts/fbgemm_gpu_build.bash b/.github/scripts/fbgemm_gpu_build.bash index fd76b5669d..1a7ca88264 100644 --- a/.github/scripts/fbgemm_gpu_build.bash +++ b/.github/scripts/fbgemm_gpu_build.bash @@ -416,6 +416,9 @@ __print_library_infos () { echo "[CHECK] Listing out external shared libraries linked:" print_exec ldd "${library}" + + echo "[CHECK] Displaying ELF information:" + print_exec readelf -d "${library}" echo "################################################################################" echo "" echo "" diff --git a/.github/scripts/utils_build.bash b/.github/scripts/utils_build.bash index 1191bf34d1..60127ed053 100644 --- a/.github/scripts/utils_build.bash +++ b/.github/scripts/utils_build.bash @@ -297,6 +297,7 @@ install_build_tools () { ncurses \ ninja \ openblas \ + patchelf \ scikit-build \ wheel) || return 1 diff --git a/fbgemm_gpu/CMakeLists.txt b/fbgemm_gpu/CMakeLists.txt index d56a9ca368..410a19be40 100644 --- a/fbgemm_gpu/CMakeLists.txt +++ b/fbgemm_gpu/CMakeLists.txt @@ -112,3 +112,7 @@ if(NOT FBGEMM_CPU_ONLY AND NOT USE_ROCM) # add_subdirectory(experimental/gen_ai) endif() + + +install(CODE "execute_process(COMMAND sh ../.github/scripts/fbgemm_gpu_postbuild.bash") +# ; patchelf --remove-rpath *.so)